From mboxrd@z Thu Jan 1 00:00:00 1970 From: Holger Brunck Date: Tue, 14 Jun 2011 08:29:41 +0200 Subject: [U-Boot] [PATCH v2 4/5] arm/km: replace suenx targets with km_kirkwood In-Reply-To: References: Message-ID: <4DF6FFD5.8050301@keymile.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Prafulla, On 06/13/2011 10:58 AM, Prafulla Wadaskar wrote: >> >> So we should add this include and remove some of the defines which are >> part of arch-kirkwood/config.h >> from our km_arm.h. But at one point we have to change arch- >> kirkwood/config.h. There is: >> >> #ifdef CONFIG_CMD_I2C >> #ifndef CONFIG_SOFT_I2C >> #define CONFIG_I2C_MVTWSI >> #define CONFIG_SYS_I2C_SLAVE 0x0 >> >> This wouldn't work for us because we have CONFIG_CMD_I2C enabled but we >> use SOFT_I2C and not HARD_I2C >> >> I think it is correct if we change it to: >> #ifdef CONFIG_CMD_I2C >> +#ifndef CONFIG_SOFT_I2C >> #define CONFIG_I2C_MVTWSI >> +#endif >> #define CONFIG_SYS_I2C_SLAVE 0x0 >> >> Prafulla if you don't object to this change I would send a patch on >> tuesday when I'm back at work to >> change this and to fix the build error. > > Hi Holger > Ack, Pls send the patch for the same. Also send a patch to resolve build error. May be those could be two standalone patches. > yes I prepare two patches. I fix this on top of current u-boot master and rebase the patch serie on top of it. Maybe you want to send this fixes upstream for inclusion in v2011.06... Best regards Holger