public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] OMAP3 clocks initialization not consistent with x-loader?
Date: Wed, 15 Jun 2011 10:56:11 +0300	[thread overview]
Message-ID: <4DF8659B.3050905@compulab.co.il> (raw)

Hi,


x-loader has the following comment and if statement for all boards supporting omap36xx SoC:

----------------------cut----------------------------------------

    /*

     * On OMAP3630, DDR data corruption has been observed on OFF mode
     * exit if the sys clock was lower than 26M. As a work around,
     * OMAP3630 is operated at 26M sys clock and this internal division
     * is not performed.
     */
    if((is_cpu_family() != CPU_OMAP36XX) && (sys_clkin_sel > 2)) {
        sr32(PRM_CLKSRC_CTRL, 6, 2, 2);/* input clock divider */
        clk_index = sys_clkin_sel/2;
    } else {
        sr32(PRM_CLKSRC_CTRL, 6, 2, 1);/* input clock divider */
        clk_index = sys_clkin_sel;
    }
----------------------cut----------------------------------------


U-Boot's omap3 clock initialization does not have that check for omap36xx.

Shouldn't we have it also in U-Boot to workaround that DDR data corruption issue?



-- 
Regards,
Igor.

                 reply	other threads:[~2011-06-15  7:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DF8659B.3050905@compulab.co.il \
    --to=grinberg@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox