From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jaehoon Chung <jh80.chung@samsung.com>
Date: Wed, 15 Jun 2011 17:12:13 +0900
Subject: [U-Boot] [PATCH] mmc: sdhci: rework Samsung specfic code
In-Reply-To: <BANLkTimQc=yXeC5tMv61+sge7URG6sm6EQ@mail.gmail.com>
References: <BANLkTim7vB_rZWQjSJ-biNufE20ZT_Jp4Q@mail.gmail.com>
	<1308062890-16740-1-git-send-email-robherring2@gmail.com>
	<BANLkTimQc=yXeC5tMv61+sge7URG6sm6EQ@mail.gmail.com>
Message-ID: <4DF8695D.3010403@samsung.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Tested-by: Jaehoon Chung <jh80.chung@samsung.com>

But Mr.Kang mentioned missing arch/arm/include/asm/arch-s5pc1xx/cpu.h
Need the below patch..
(s5pc2xx and s5pc1xx are working well)

diff --git a/arch/arm/include/asm/arch-s5pc1xx/cpu.h b/arch/arm/include/asm/arch-s5pc1xx/cpu.h
index e74959f..86b7bd2 100644
--- a/arch/arm/include/asm/arch-s5pc1xx/cpu.h
+++ b/arch/arm/include/asm/arch-s5pc1xx/cpu.h
@@ -94,6 +94,9 @@ SAMSUNG_BASE(mmc, MMC_BASE)
 SAMSUNG_BASE(sromc, SROMC_BASE)
 SAMSUNG_BASE(timer, PWMTIMER_BASE)
 SAMSUNG_BASE(uart, UART_BASE)
+
+#define samsung_get_base_mmc_offset(idx)	(samsung_get_base_mmc() + \
+						 0x10000 * (idx))
 #endif
 
 #endif	/* _S5PC1XX_CPU_H */

Regards,
Jaehoon Chung

Minkyu Kang wrote:
> Dear Rob Herring,
> 
> On 14 June 2011 23:48, Rob Herring <robherring2@gmail.com> wrote:
>>  arch/arm/include/asm/arch-s5pc1xx/mmc.h  |   73 ------------------------------
>>  arch/arm/include/asm/arch-s5pc2xx/cpu.h  |    4 ++
>>  arch/arm/include/asm/arch-s5pc2xx/mmc.h  |   73 ------------------------------
>>  board/samsung/goni/goni.c                |    4 +-
>>  board/samsung/universal_c210/universal.c |    6 +-
>>  drivers/mmc/sdhci.c                      |   31 +++++++------
>>  include/sdhci.h                          |   62 +++++++++++++++++++++++++
>>  7 files changed, 88 insertions(+), 165 deletions(-)
>>  delete mode 100644 arch/arm/include/asm/arch-s5pc1xx/mmc.h
>>  delete mode 100644 arch/arm/include/asm/arch-s5pc2xx/mmc.h
>>  create mode 100644 include/sdhci.h
>>
>> --- a/arch/arm/include/asm/arch-s5pc2xx/cpu.h
>> +++ b/arch/arm/include/asm/arch-s5pc2xx/cpu.h
>> @@ -108,6 +108,10 @@ SAMSUNG_BASE(uart, UART_BASE)
>>  SAMSUNG_BASE(usb_phy, USBPHY_BASE)
>>  SAMSUNG_BASE(usb_otg, USBOTG_BASE)
>>  SAMSUNG_BASE(watchdog, WATCHDOG_BASE)
>> +
>> +#define samsung_get_base_mmc_offset(idx)       (samsung_get_base_mmc() + \
>> +                                                0x10000 * (idx))
>> +
>>  #endif
>>
>>  #endif /* _S5PC2XX_CPU_H */
> 
> Looks fine.
> But, missing arch/arm/include/asm/arch-s5pc1xx/cpu.h
> 
> Dear Jaehoon,
> 
> Please test this patch on s5pc1xx and s5pc2xx.
> 
> Thanks
> Minkyu Kang