[U-Boot] [PATCH v2 08/22] omap: add spl support

Aneesh V
2011-06-07T09:15:03Z

Hi Wolfgang,

On Thursday 26 May 2011 07:21 PM, Aneesh V wrote:
> Hi Wolfgang,
> On Tuesday 17 May 2011 01:46 PM, Wolfgang Denk wrote:
>> Dear Aneesh V,
>>
>> In message<4DD21CD8.2080409@ti.com> you wrote:
>>>
>>>> There are common, board independent parts both in spl/nand and
>>>> spl/onenand.
>>>
>>> How about having them at the root level in 'spl/' ?
>>
>> Why? It seems more logical to me to group nand and onenand related
>> files in their own subdirectories.
>
> I do not have any issue in having media specific files in their
> respective directories. However, I would like to see the 'Makefile's
> coming from the same directory tree irrespective of the media. So, how
> about something like this:
>
> spl/
> mmc/
> nand/
> one-nand/
> board/<vendor>/<board>/Makefile
>
> The idea is to have the board level Makefile in 'spl/board/<vendor>
> /<board>/' no matter what the SPL type is. This will help in better
> consolidation of SPLs.
>
> I see 3 SPL use-cases in general:
> 1. A single SPL that supports multiple media(suitable for SoCs with
> large internal RAM)
> 2. A single SPL supporting a single media(the board supports only one
> media)
> 3. Multiple SPLs for the same board each supporting a different
> memory device(maybe preferred over 1 to keep the foot-print of each
> small).
>
> Supporting (1) and (2) is straight forward with the above directory
> structure.
>
> To support (3) the board level Makefile should conditionally
> include the respective image file in the target 'all' based on CONFIG
> options. For instance 'all' may include 'onenand-ipl-2k.bin' if
> CONFIG_ONENAND_U_BOOT is defined and so on.
>
> Please let me know if any of you have better ideas. I would like to
> finalize on this before re-working on my patch-set.

Are you fine with this scheme. Appreciate if you could let me know your
thoughts on this. I am waiting for your inputs to start the re-work.

best regards,
Aneesh