[U-Boot] [PATCH v2 09/22] omap4: add spl support for OMAP4 SDP

Wolfgang Denk
2011-05-17T12:53:09Z

Dear Aneesh V,

In message <4DD26B36.4050102@ti.com> you wrote:
>
> And how do you distinguish between the two cases at the top level
> Makefile? Using a CONFIG flag or on a per platform basis?

The decision should not be make in the top level makefile, but in
spl/Makefile. And this can simply check if a board directory exists
in the first place.

> Why not just invoke the board level Makefile from the top-level
> Makefile and let it decide about the code-reuse by doing something like
> I did?

Because then we need board specific directories and board specific
Makefiles even for those boards where no board specific code exists,
and all these Makefiles will be semi-identical copies of each other.

> > Then we should adapt the directory and Makefile structure and allow
> > for such common code without need for separate spl/board/
> > directories.
>
> Do you have any specific proposals? I have a feeling that this may get
> un-necessarily complicated.

Having to maintain multiple copies of identical Makefiles is more
complicated and error prone in the long run. Let's rather spoend a few
thoughts initially and solve this problem before it spreads.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"It ain't so much the things we don't know that get us in trouble.
It's the things we know that ain't so." - Artemus Ward aka Charles
Farrar Brown