[U-Boot] [PATCH v2 09/22] omap4: add spl support for OMAP4 SDP

Aneesh V
2011-05-17T12:33:58Z

Hi Wolfgang,

On Tuesday 17 May 2011 01:49 PM, Wolfgang Denk wrote:
> Dear Aneesh V,
>
> In message<4DD21FB9.6070901@ti.com> you wrote:
>>
>> The top-level make rule being the following, we will need a Makefile in
>> the board directory, right?
>>
>> +SPL :$(TIMESTAMP_FILE) $(VERSION_FILE) depend tools
>> + $(MAKE) -C spl/board/$(BOARDDIR) all
>
> Maybe this needs to be tweaked to allow for boards that don;t require
> board specific code.
>

And how do you distinguish between the two cases at the top level
Makefile? Using a CONFIG flag or on a per platform basis?

Why not just invoke the board level Makefile from the top-level
Makefile and let it decide about the code-reuse by doing something like
I did?

>> In fact, code is already common. All OMAP code specific to SPL comes
>> from spl/board/ti/spl-omap.c . All OMAP code shared with OMAP U-Boot
>> comes from the respective directory within arch/arm/cpu/armv7/*
>>
>> In the interest of simplicity I deferred all board specific
>> initialization of OMAP4(mainly mux) to U-Boot. So, SPL is board
>> independent today for OMAP4.
>
> Then we should adapt the directory and Makefile structure and allow
> for such common code without need for separate spl/board/
> directories.

Do you have any specific proposals? I have a feeling that this may get
un-necessarily complicated.

Best regards,
Aneesh