public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Rod Boyce <uboot@teamboyce.co.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch] For  bug in UBIFS function ubifs_finddir
Date: Sat, 18 Jun 2011 10:51:11 +0100	[thread overview]
Message-ID: <4DFC750F.7050605@teamboyce.co.uk> (raw)
In-Reply-To: <d69cb0e903661da8720212661706b0b4.squirrel@www.teamboyce.co.uk>


Free private_data member element before freeing file structure.  This
was causing malloc to crash.  Also remove unnecessary variable
assigments after file structure was free'd.

Signed-off-by: Rod Boyce <uboot@teamboyce.co.uk>
------------------------------- fs/ubifs/ubifs.c 
------------------------------
diff --git a/fs/ubifs/ubifs.c b/fs/ubifs/ubifs.c
index 5a5c739..61f70b2 100644
--- a/fs/ubifs/ubifs.c
+++ b/fs/ubifs/ubifs.c
@@ -360,6 +360,8 @@
          return err;
      }

+    if (file->private_data)
+        kfree(file->private_data);
      if (file)
          free(file);
      if (dentry)
@@ -367,10 +369,6 @@
      if (dir)
          free(dir);

-    if (file->private_data)
-        kfree(file->private_data);
-    file->private_data = NULL;
-    file->f_pos = 2;
      return 0;
  }

  reply	other threads:[~2011-06-18  9:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-16 11:13 [U-Boot] Possible bug in UBIFS function ubifs_finddir Rod Boyce
2011-06-18  9:51 ` Rod Boyce [this message]
2011-06-29  8:34   ` [U-Boot] [Patch] For " Stefan Roese
2011-06-29 11:42     ` Detlev Zundel
2011-06-29 11:35   ` Detlev Zundel
2011-07-25 21:57   ` Wolfgang Denk
2011-07-28 13:27   ` [U-Boot] [PATCH] ubifs: Fix bad free() sequence in ubifs_finddir() Wolfgang Denk
2011-07-28 14:09     ` Rod Boyce
2011-08-19 15:22     ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DFC750F.7050605@teamboyce.co.uk \
    --to=uboot@teamboyce.co.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox