From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot PATCH MX31:] smc911x MII made available
Date: Mon, 20 Jun 2011 14:30:17 +0200 [thread overview]
Message-ID: <4DFF3D59.8090805@denx.de> (raw)
In-Reply-To: <1308550254-2897-1-git-send-email-Helmut.Raiger@hale.at>
On 06/20/2011 08:10 AM, Helmut.Raiger at hale.at wrote:
> From: Helmut Raiger <helmut.raiger@hale.at>
Hi Helmut,
>
> The driver already had the MII functions, but they have not been
> registered using miiphy_register().
>
> Signed-off-by: Helmut Raiger <helmut.raiger@hale.at>
Not noted before, thanks for fixing it. Only to remark the issue, on
boards with SMC911x (at least the one I tested your patch) and
CONFIG_CMD_MII set, a simple "mii info" returns "Read MDIO failed.."
You should always put in CC the maintainer for your patches. Because
this patch is related to network, you should send your changes to
Wolfgang Denk (Network Maintaner), too. I have already set his name in CC.
> +#if defined(CONFIG_MII) || defined(CONFIG_CMD_MII)
> +/* wrapper for smc911x_miiphy_read */
> +static int _phy_read(char *devname, u8 phy, u8 reg, u16 *val)
Is there some reason to use name starting with _ ? They have special
meaning, and there is no need here.
I have tested your patch on the mx35pdk board.
Tested-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2011-06-20 12:30 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 6:10 [U-Boot] [U-Boot PATCH MX31:] smc911x MII made available Helmut.Raiger at hale.at
2011-06-20 12:30 ` Stefano Babic [this message]
2011-06-20 14:36 ` Helmut Raiger
2011-06-27 7:22 ` [U-Boot] [PATCH] " helmut.raiger at hale.at
2011-06-27 19:29 ` Mike Frysinger
2011-06-29 10:12 ` helmut.raiger at hale.at
2011-06-30 13:57 ` Luca Ceresoli
2011-06-30 14:02 ` [U-Boot] [PATCH RFC] smc911x: enable mii commands Luca Ceresoli
2011-07-04 9:41 ` Helmut Raiger
2011-07-04 10:29 ` [U-Boot] [PATCH 1/2] net/eth.c: make eth_get_dev_by_name(NULL) safe helmut.raiger at hale.at
2011-07-04 10:29 ` [U-Boot] [PATCH 2/2] smc911x MII made available helmut.raiger at hale.at
2011-09-07 12:33 ` [U-Boot] [U-Boot,2/2] " Stefano Babic
2011-09-07 13:06 ` Helmut Raiger
2011-09-07 13:12 ` Stefano Babic
2011-09-07 21:50 ` [U-Boot] [PATCH 2/2] " Wolfgang Denk
2011-09-08 11:04 ` [U-Boot] [PATCH] smc911x: Fix build warnings Wolfgang Denk
2011-09-09 21:57 ` Wolfgang Denk
2011-07-05 3:44 ` [U-Boot] [PATCH 1/2] net/eth.c: make eth_get_dev_by_name(NULL) safe Mike Frysinger
2011-07-06 7:15 ` Helmut Raiger
2011-07-06 19:38 ` Mike Frysinger
2011-07-07 6:12 ` Helmut Raiger
2011-07-07 10:24 ` Detlev Zundel
2011-07-07 17:46 ` Mike Frysinger
2011-07-11 9:53 ` Helmut Raiger
2011-07-12 6:37 ` Mike Frysinger
2011-07-12 9:22 ` Detlev Zundel
2011-07-12 20:49 ` Mike Frysinger
2011-07-13 11:34 ` Detlev Zundel
2011-07-13 6:32 ` Helmut Raiger
2011-07-13 11:46 ` Detlev Zundel
2011-07-14 9:14 ` Helmut Raiger
2011-07-14 17:58 ` Mike Frysinger
2011-08-22 8:45 ` [U-Boot] [PATCH V2 1/2] net/eth.c: throw BUG for eth_get_dev_by_name(NULL) Helmut Raiger
2011-08-22 10:05 ` Sergei Shtylyov
2011-08-22 10:17 ` [U-Boot] [PATCH " Helmut Raiger
2011-08-22 16:05 ` Mike Frysinger
2011-09-08 11:08 ` Wolfgang Denk
2011-07-14 18:24 ` [U-Boot] [PATCH 1/2] net/eth.c: make eth_get_dev_by_name(NULL) safe Mike Frysinger
2011-07-07 16:46 ` Albert ARIBAUD
2011-07-11 10:10 ` Helmut Raiger
2011-07-14 13:53 ` Albert ARIBAUD
2011-08-31 7:41 ` [U-Boot] Anything missing? Helmut Raiger
2011-08-31 7:45 ` Wolfgang Denk
2011-09-07 5:40 ` [U-Boot] [U-Boot PATCH MX31:] smc911x MII made available, ping? Helmut Raiger
2011-09-07 12:37 ` Stefano Babic
2011-09-07 21:47 ` Wolfgang Denk
2011-09-08 6:13 ` Helmut Raiger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFF3D59.8090805@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox