[U-Boot] [PATCH v2 09/22] omap4: add spl support for OMAP4 SDP

Wolfgang Denk
2011-05-16T15:48:14Z

Dear Aneesh V,

In message <4DD134DD.6040802@ti.com> you wrote:
>
> >> create mode 100644 spl/board/ti/omap4.mk
> >> create mode 100644 spl/board/ti/rules-omap.mk
> >
> > We do you introduce these files? Please omit them, and use a plain
> > Makefile instead.
>
> I introduced them because 'spl/board/ti/sdp4430/Makefile' and 'spl/board
> /ti/panda/Makefile' were exactly same and wanted to re-use the make
> rules.

But in the result, the Makefiles are still the same, aren't they?

> I indeed wanted to abstract it out even further in future so that the
> make rules can be shared between OMAP3 and OMAP4 too. This way the
> changes needed to support a new board will be lesser and maintenance
> will be easier while adding new features.
>
> For instance, if I have to add NAND support today I just need to update
> omap4.mk instead of updating the Makefile of both panda and SDP.
>
> This re-use will be evident when you see a later patch that
> replicates the same Makefile for panda.

Can you please rather try and move this to a common directory level,
then?

I have a bad feeling about this. If the Makefiles are the same, then
the code is probably more or less the same, also. Eventually larger
parts of the code should be moved to a common directory, too?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A man either lives life as it happens to him, meets it head-on and
licks it, or he turns his back on it and starts to wither away.
-- Dr. Boyce, "The Menagerie" ("The Cage"), stardate unknown