[U-Boot] [PATCH v2 08/22] omap: add spl support

Wolfgang Denk
2011-06-15T12:04:00Z

Dear Aneesh,

In message <4DF88F45.9090905@ti.com> you wrote:
>
> > I don't get this. Why don't we just pass the required make target
> > from the top level Makefile? If we want to build "onenand-ipl-2k.bin"
> > then this would result in running "make onenand-ipl-2k.bin" in the
> > respective directory - this is then also independent of whether this
> > image contains support for one specific boot device or for any set of
> > different devices.
>
> Then you will have to deal with many such images in the top-level
> Makefile(u-boot/Makefile). Instead why not have just one rule like the
> below in the top-level Makefile for all the different spl's:
>
>
> SPL :$(TIMESTAMP_FILE) $(VERSION_FILE) depend tools
> $(MAKE) -C spl/board/$(BOARDDIR) all
>
> And leave the rest to the board level Makefiles

We just discussed that there are cases where there may be no board
level Makefile be needed at all, because there is no board specific
code to handle.

Also, why would there be many such images? We might just want to use
more reasonable names. We have "u-boot.bin", and this works fine for
all boards, so why cannot we make it that "u-boot-nand.bin" works for
all boards booting from NAND, and in general "u-boot-<DEV>.bin" works
for all boards booting from a <DEV> boot device?

Instead of "onenand-ipl-2k.bin", we would just have a generic
"u-boot-onenand.bin"

> Of course, this is assuming the existing Makefile structure. With the
> new Makefile structure you are suggesting this may not hold good.

Why not?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Wenn das dann in die Hose geht, nehme ich es auf meine Kappe.
-- Rudi V?ller, 15. Nov 2003