[U-Boot] [PATCH v2 10/22] omap4: utility function to identify the context of hw init

Wolfgang Denk
2011-05-16T15:50:04Z

Dear Aneesh V,

In message <4DD135D0.8070805@ti.com> you wrote:
>
> >> + return OMAP_INIT_CONTEXT_XIP_UBOOT;
> >
> > What exactly is OMAP_INIT_CONTEXT_XIP_UBOOT?
> >
> > Do you mean the situation when booting from NOR flash, before
> > relocation?
>
> Yes, this is for the NOR case.

Then please call it like that. XIP has a special emaning, that may or
may not be related to running from ROM.

> > Eventually the "loaded by" definition is not so good, as it does not
> > really cover the NOR boot case.
>
> Please note that "loaded by" definition is not there for all the
> options. The definition is the 'context' in which the init code is
> executing.

So please get rid of the "LOADED_BY" names.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Today's robots are very primitive, capable of understanding only a
few simple instructions such as 'go left', 'go right', and 'build
car'." - John Sladek