From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] OMAP[34]: fix broken timer
Date: Wed, 29 Jun 2011 08:35:20 +0200 [thread overview]
Message-ID: <4E0AC7A8.2010802@aribaud.net> (raw)
In-Reply-To: <1293496390-13372-1-git-send-email-john.rigby@linaro.org>
Hi John,
Le 28/12/2010 01:33, John Rigby a ?crit :
> As implemented now the timer used to implement __udelay counts
> to 0xffffffff and then gets stuck there because the the programmed
> reload value is 0xffffffff. This value is not only wrong but
> illegal according to the reference manual.
>
> One can reproduce the bug by leaving a board at the u-boot prompt
> for sometime then issuing a sleep command. The sleep will hang
> forever.
>
> The timer is a count up timer that reloads as it rolls over
> from 0xffffffff so the correct load value is 0.
>
> Change TIMER_LOAD_VAL from 0xffffffff to 0 and introduce
> a new constant called TIMER_OVERFLOW_VAL set to 0xffffffff.
>
> Signed-off-by: John Rigby<john.rigby@linaro.org>
Applied to u-boot-arm/master, thanks.
Amicalement,
--
Albert.
prev parent reply other threads:[~2011-06-29 6:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-28 0:33 [U-Boot] [PATCH] OMAP[34]: fix broken timer John Rigby
2011-06-28 5:43 ` Igor Grinberg
2011-06-29 6:35 ` Albert ARIBAUD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0AC7A8.2010802@aribaud.net \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox