From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aneesh V Date: Thu, 30 Jun 2011 11:42:32 +0530 Subject: [U-Boot] [RFC PATCH 6/7] omap: common spl support for OMAP3/4 In-Reply-To: <4E0C113B.3070303@denx.de> References: <1309352967-5719-7-git-send-email-aneesh@ti.com> <4E0C113B.3070303@denx.de> Message-ID: <4E0C13D0.5040001@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Heiko, On Thursday 30 June 2011 11:31 AM, Heiko Schocher wrote: > Hello Aneesh, > > Aneesh V wrote: >> Signed-off-by: Aneesh V >> --- >> arch/arm/cpu/armv7/omap-common/Makefile | 9 ++-- >> arch/arm/cpu/armv7/omap-common/spl.c | 56 ++++++++++++++++++++++++++++ >> arch/arm/cpu/armv7/omap-common/spl.lds | 62 +++++++++++++++++++++++++++++++ >> 3 files changed, 123 insertions(+), 4 deletions(-) >> create mode 100644 arch/arm/cpu/armv7/omap-common/spl.c >> create mode 100644 arch/arm/cpu/armv7/omap-common/spl.lds >> > [...] >> diff --git a/arch/arm/cpu/armv7/omap-common/spl.c b/arch/arm/cpu/armv7/omap-common/spl.c >> new file mode 100644 >> index 0000000..b5a5f3c >> --- /dev/null >> +++ b/arch/arm/cpu/armv7/omap-common/spl.c > [...] >> @@ -0,0 +1,56 @@ >> +void board_init_f(ulong dummy) >> +{ >> + debug(">>board_init_f()\n"); >> + relocate_code(CONFIG_SYS_SPL_STACK,&gdata, CONFIG_SYS_SPL_TEXT_BASE); >> + debug("< > This debug printf will never occur ;-) Indeed. Thanks for pointing out. > > BTW: Do you really need to relocate code? You could just load the 2nd > stage loader to ram from board_init_f, or? I am passing the same address as I am executing from as the target for the relocation, so the relocation will not happen, instead BSS will be initialized. That's what I am calling it for. Initially I had my own routine for clearing BSS. Then I decided to re-use it from start.S BTW, this series is not complete as far as SPL support is concerned. It doesn't even build due to many undefined references. It serves only as a prototype for the framework part. br, Aneesh