public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Matthias Weißer" <weisserm@arcor.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] imx: Use correct imx25 reset.c
Date: Thu, 30 Jun 2011 13:35:06 +0200	[thread overview]
Message-ID: <4E0C5F6A.8000504@arcor.de> (raw)
In-Reply-To: <20110630104638.8877415AEB8D@gemini.denx.de>

Hello Wolfgang

Am 30.06.2011 12:46, schrieb Wolfgang Denk:
>> +
>> +$(TOPDIR)/include/asm/arch/asm-offsets.h:	$(TOPDIR)/include/autoconf.mk.dep \
>> +	./asm-offsets.s
>> +	@echo Generating $@
>> +	$(TOPDIR)/tools/scripts/make-asm-offsets ./asm-offsets.s $@
>> +
>> +asm-offsets.s:	$(TOPDIR)/include/autoconf.mk.dep \
>> +	./asm-offsets.c
>> +	$(CC) -DDO_DEPS_ONLY \
>> +		$(CFLAGS) $(CFLAGS_$(BCURDIR)/$(@F)) $(CFLAGS_$(BCURDIR)) \
>> +		-o $@ ./asm-offsets.c -c -S
>> --
>
> NAK.
>
> See previous comments to Setano's postings.  It makes no sense to copy
> identical lines into a large number of Makefiles.

OK. I will address this point in a v2 of the series.

Matthias

  reply	other threads:[~2011-06-30 11:35 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-30  9:57 [U-Boot] [PATCH 0/5] Add support for zmx25 board Matthias Weisser
2011-06-30  9:57 ` [U-Boot] [PATCH 1/5] imx: Add get_tbclk() function for imx25 Matthias Weisser
2011-06-30 15:38   ` Stefano Babic
2011-07-04  5:56     ` Matthias Weißer
2011-06-30  9:57 ` [U-Boot] [PATCH 2/5] imx: Use correct imx25 reset.c Matthias Weisser
2011-06-30 10:46   ` Wolfgang Denk
2011-06-30 11:35     ` Matthias Weißer [this message]
2011-06-30 10:49   ` Wolfgang Denk
2011-06-30 11:30     ` Matthias Weißer
2011-06-30  9:57 ` [U-Boot] [PATCH 3/5] imx: Add support for USB EHCI on imx25 Matthias Weisser
2011-06-30 15:48   ` Stefano Babic
2011-07-05 20:07     ` Marek Vasut
2011-06-30  9:57 ` [U-Boot] [PATCH 4/5] imx: Add auto generation of asm-offsets.h for imx25 Matthias Weisser
2011-06-30  9:57 ` [U-Boot] [PATCH 5/5] imx: Add support for zmx25 board Matthias Weisser
2011-06-30 10:44   ` Wolfgang Denk
2011-06-30 13:44     ` Matthias Weißer
2011-06-30 15:36   ` Stefano Babic
2011-07-04  6:28     ` Matthias Weißer
2011-07-06 10:28 ` [U-Boot] [PATCH v2 0/6] " Matthias Weisser
2011-07-06 10:28 ` [U-Boot] [PATCH v2 1/6] imx: Add get_tbclk() function for imx25 Matthias Weisser
2011-07-13 11:33   ` Stefano Babic
2011-07-06 10:28 ` [U-Boot] [PATCH v2 2/6] imx: Use correct imx25 reset.c Matthias Weisser
2011-07-13 11:33   ` Stefano Babic
2011-07-06 10:28 ` [U-Boot] [PATCH v2 3/6] imx: Add support for USB EHCI on imx25 Matthias Weisser
2011-07-13 11:34   ` Stefano Babic
2011-07-06 10:28 ` [U-Boot] [PATCH v2 4/6] imx: Add auto generation of asm-offsets.h for imx25 Matthias Weisser
2011-07-13 11:35   ` Stefano Babic
2011-07-06 10:28 ` [U-Boot] [PATCH v2 5/6] imx: Make imx25 compatible to mxc_gpio driver and fix in tx25 Matthias Weisser
2011-07-13 11:35   ` Stefano Babic
2011-07-06 10:28 ` [U-Boot] [PATCH v2 6/6] imx: Add support for zmx25 board Matthias Weisser
2011-07-13 11:36   ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E0C5F6A.8000504@arcor.de \
    --to=weisserm@arcor.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox