From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/8] Adds wait to atmel_usart serial_init function
Date: Fri, 01 Jul 2011 16:03:42 +0400 [thread overview]
Message-ID: <4E0DB79E.60301@mvista.com> (raw)
In-Reply-To: <1309462387-22926-7-git-send-email-awaterman@dawning.com>
Hello.
On 30-06-2011 23:33, Alex Waterman wrote:
> Adds a short busy loop wait to the atmel_usart.c serial_init()
> function.
> Signed-off-by: Alex Waterman<awaterman@dawning.com>
> diff --git a/drivers/serial/atmel_usart.c b/drivers/serial/atmel_usart.c
> index e326b2b..e355706 100644
> --- a/drivers/serial/atmel_usart.c
> +++ b/drivers/serial/atmel_usart.c
> @@ -47,6 +47,8 @@ void serial_setbrg(void)
>
> int serial_init(void)
> {
> +
> + volatile int i = 0;
Why 'volatile'? Also, there shouldn't be an empty line before it but there
should be one after it...
> atmel_usart3_t *usart = (atmel_usart3_t *)CONFIG_USART_BASE;
>
> writel(USART3_BIT(RSTRX) | USART3_BIT(RSTTX),&usart->cr);
> @@ -61,6 +63,10 @@ int serial_init(void)
> | USART3_BF(NBSTOP, USART3_NBSTOP_1)),
> &usart->mr);
>
> + /* Short wait to let the serial port init. */
> + for (; i < 10000; i++)
> + ;
> +
> return 0;
> }
WBR, Sergei
next prev parent reply other threads:[~2011-07-01 12:03 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 22:47 [U-Boot] Is somebody workin on getting the AT91SAM9G45EKES working on the latest build? William C. Landolina
2011-06-30 12:32 ` Alex Waterman
2011-06-30 13:12 ` Albert ARIBAUD
2011-06-30 20:01 ` Alex Waterman
2011-06-30 19:14 ` [U-Boot] [PATCH 0/8] Fixes compilation for the at91sam9m10g45ek Alex.Waterman.awaterman at dawning.com
2011-06-30 19:14 ` [U-Boot] [PATCH 1/8] Remove old config stuff from Makefile Alex.Waterman.awaterman at dawning.com
2011-06-30 19:14 ` [U-Boot] [PATCH 2/8] Update at91sam9m10g45_devices.c to fix compile errors Alex.Waterman.awaterman at dawning.com
2011-06-30 19:14 ` [U-Boot] [PATCH 3/8] Fix compile problem for some boards in the clock code Alex.Waterman.awaterman at dawning.com
2011-06-30 19:14 ` [U-Boot] [PATCH 4/8] Updates the at91sam9mg45_matrix.h header to new defines Alex.Waterman.awaterman at dawning.com
2011-06-30 19:14 ` [U-Boot] [PATCH 5/8] Updates the board specific files for the at91sam9mg45ek Alex.Waterman.awaterman at dawning.com
2011-06-30 19:14 ` [U-Boot] [PATCH 6/8] Adds wait to atmel_usart serial_init function Alex.Waterman.awaterman at dawning.com
2011-06-30 19:14 ` [U-Boot] [PATCH 7/8] Updates the at91sam9m10g45ek.h config file Alex.Waterman.awaterman at dawning.com
2011-06-30 19:14 ` [U-Boot] [PATCH 8/8] Updates the boards.cfg file Alex.Waterman.awaterman at dawning.com
[not found] ` <657FC3AB549C7F4DB01F4397232ED733A2DACD735E@Exchange2007.techatl.com>
2011-06-30 19:32 ` [U-Boot] Is somebody workin on getting the AT91SAM9G45EKES working on the latest build? Alex Waterman
2011-06-30 20:54 ` William C. Landolina
2011-07-01 13:15 ` Alex Waterman
2011-07-01 19:37 ` William C. Landolina
2011-06-30 19:32 ` [U-Boot] [PATCH 0/8] Fixes compilation for the at91sam9m10g45ek Alex Waterman
2011-06-30 19:33 ` [U-Boot] [PATCH 1/8] Remove old config stuff from Makefile Alex Waterman
2011-06-30 19:33 ` [U-Boot] [PATCH 2/8] Update at91sam9m10g45_devices.c to fix compile errors Alex Waterman
2011-07-04 7:35 ` Reinhard Meyer
2011-06-30 19:33 ` [U-Boot] [PATCH 3/8] Fix compile problem for some boards in the clock code Alex Waterman
2011-07-04 7:37 ` Reinhard Meyer
2011-06-30 19:33 ` [U-Boot] [PATCH 4/8] Updates the at91sam9mg45_matrix.h header to new defines Alex Waterman
2011-06-30 19:33 ` [U-Boot] [PATCH 5/8] Updates the board specific files for the at91sam9mg45ek Alex Waterman
2011-06-30 19:33 ` [U-Boot] [PATCH 6/8] Adds wait to atmel_usart serial_init function Alex Waterman
2011-07-01 12:03 ` Sergei Shtylyov [this message]
2011-07-01 12:37 ` Alex Waterman
2011-07-01 15:17 ` Albert ARIBAUD
2011-07-04 7:42 ` Reinhard Meyer
2011-06-30 19:33 ` [U-Boot] [PATCH 7/8] Updates the at91sam9m10g45ek.h config file Alex Waterman
2011-07-04 7:50 ` Reinhard Meyer
2011-06-30 19:33 ` [U-Boot] [PATCH 8/8] Updates the boards.cfg file Alex Waterman
2011-07-04 7:52 ` Reinhard Meyer
2011-08-02 8:19 ` [U-Boot] [PATCH 0/8] Fixes compilation for the at91sam9m10g45ek Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0DB79E.60301@mvista.com \
--to=sshtylyov@mvista.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox