From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it.
Date: Tue, 05 Jul 2011 13:46:03 +0300 [thread overview]
Message-ID: <4E12EB6B.9030200@compulab.co.il> (raw)
In-Reply-To: <20110705100437.12CB013D91D1@gemini.denx.de>
On 07/05/11 13:04, Wolfgang Denk wrote:
> Dear Igor Grinberg,
>
> In message <4E12BF5D.6080307@compulab.co.il> you wrote:
>>> + debug("\nWarning: machid not set! Linux will not finish booting.\n\n");
>>> + }
>>> +#endif
>> Is there a reason to close this in ifdef DEBUG? and also use debug()?
>> I would print this in any case, because machid must be set for Linux to boot
>> properly.
>> This message will not hurt anyone (just add ~50 bytes, this is not an spl code)
>> and if someone hacks Linux to boot in any case (without checking the machid),
>> then he can also hack U-Boot and remove the message (if it bothers him).
> I think "Warning: machid not set" should be sufficient.
Agreed!
> Note: we should't print excessive newlines. No \n at the begin of the
> string, only one at the end.
>
> Best regards,
>
> Wolfgang Denk
>
--
Regards,
Igor.
prev parent reply other threads:[~2011-07-05 10:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1309799825.git.charvey@matrox.com>
2011-07-04 17:43 ` [U-Boot] [PATCH 1/5] Added documentation for CONFIG_SYS_TEXT_BASE for ARM Christopher Harvey
2011-07-04 19:39 ` Wolfgang Denk
2011-07-04 17:43 ` [U-Boot] [PATCH 2/5] Added extra documentation about how the relocation address to RAM is picked " Christopher Harvey
2011-07-04 19:43 ` Wolfgang Denk
2011-07-06 20:58 ` Christopher Harvey
2011-07-06 21:29 ` Wolfgang Denk
2011-07-07 16:10 ` Albert ARIBAUD
2011-07-04 17:44 ` [U-Boot] [PATCH 3/5] Removed unused define, CONFIG_ARMV7 Christopher Harvey
2011-07-04 18:00 ` Jason
2011-07-04 18:46 ` Christopher Harvey
2011-07-04 19:47 ` Wolfgang Denk
2011-07-04 17:45 ` [U-Boot] [PATCH 4/5] Don't compile in large memory test function by default Christopher Harvey
2011-07-07 16:13 ` Albert ARIBAUD
2011-07-04 17:45 ` [U-Boot] [PATCH 5/5] Warn when the machine ID isn't passed to an ARM kernel and u-boot is compiled in debug mode. The kernel cannot boot without it Christopher Harvey
2011-07-04 18:08 ` Jason
2011-07-04 18:55 ` Christopher Harvey
2011-07-04 19:56 ` Wolfgang Denk
2011-07-04 20:13 ` Jason
2011-07-04 20:32 ` Christopher Harvey
2011-07-04 21:24 ` Jason
2011-07-05 7:21 ` Igor Grinberg
2011-07-05 7:31 ` Igor Grinberg
2011-07-04 19:53 ` Wolfgang Denk
2011-07-05 7:38 ` Igor Grinberg
2011-07-05 10:04 ` Wolfgang Denk
2011-07-05 10:46 ` Igor Grinberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E12EB6B.9030200@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox