From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Wed, 06 Jul 2011 07:56:20 +0200 Subject: [U-Boot] [PATCH] i2c:gpio:s5p: I2C GPIO Software implementation In-Reply-To: <201107051347.01833.vapier@gentoo.org> References: <1309868621-19921-1-git-send-email-l.majewski@samsung.com> <201107051347.01833.vapier@gentoo.org> Message-ID: <4E13F904.50402@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Mike, Mike Frysinger wrote: > On Tuesday, July 05, 2011 08:23:41 Lukasz Majewski wrote: >> This commit adds I2C software support for Samsung's S5PC110 >> family of processors. >> The generic drivers/i2c/soft_i2c framework is used, with >> routines provided by this commit. > > if you simply implemented the generic gpio layer (asm/gpio.h), the soft_i2c.c > code already handles gluing to GPIO pins. then you wouldnt need a sep driver > at all. you can see the bf561-ezkit already using this code. > -mike Yes, that was my thought too. No seperate i2c driver should be needed here. bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany