[U-Boot] [RFC PATCH 1/4] Adapt config.mk for usage in spl/Makefile

Aneesh V
2011-07-08T11:40:38Z

On Friday 08 July 2011 04:49 PM, Wolfgang Denk wrote:
> Dear Aneesh V,
>
> In message<4E16D9DA.4080803@ti.com> you wrote:
>>
>>>> +CONFIG_NORMAL_UBOOT = $(if $(CONFIG_UBOOT_SPL_BUILD),,y)
>>>
>>> Is this not redundant, then?
>>
>> Yes, it is. But it was handy for conditional inclusion of source files
>> in the Makefiles, like this:
>>
>> +# used only by normal u-boot
>> +COBJS-$(CONFIG_NORMAL_UBOOT) += fileA.o
>> +# used only by SPL
>> +COBJS-$(CONFIG_UBOOT_SPL_BUILD) += fileB.o
>> +# used by SPL and normal u-boot
>> +COBJS-y += fileC.o
>>
>> Without CONFIG_NORMAL_UBOOT this becomes a little cumbersome.
>
> Hm... instead of
>
> COBJS-$(CONFIG_NORMAL_UBOOT) += fileA.o
>
> we could use
>
> COBJS-$(if $(CONFIG_UBOOT_SPL_BUILD),,y)

This is what I was trying to avoid. Isn't the above more obvious for
lay-users of make?

best regards,
Aneesh