[U-Boot] [RFC PATCH v1 6/9] scaled down version of generic libraries for SPL

Simon Schwarz
2011-07-15T12:31:38Z

Hi Daniel,

at the moment I'am playing a bit with your patch.

I stumbled over this:
> diff --git a/arch/arm/lib/Makefile b/arch/arm/lib/Makefile
> index d31321a..300c8fa 100644
> --- a/arch/arm/lib/Makefile
> +++ b/arch/arm/lib/Makefile
> @@ -26,6 +26,7 @@ include $(TOPDIR)/config.mk
> ?LIB ? ?= $(obj)lib$(ARCH).o
> ?LIBGCC = $(obj)libgcc.o
>
> +ifndef CONFIG_SPL_BUILD
> ?GLSOBJS ? ? ? ?+= _ashldi3.o
> ?GLSOBJS ? ? ? ?+= _ashrdi3.o
> ?GLSOBJS ? ? ? ?+= _divsi3.o
> @@ -45,6 +46,7 @@ COBJS-y ? ? ? += interrupts.o
> ?COBJS-y ? ? ? ?+= reset.o
> ?SOBJS-$(CONFIG_USE_ARCH_MEMSET) += memset.o
> ?SOBJS-$(CONFIG_USE_ARCH_MEMCPY) += memcpy.o
> +endif

Is it really your intention here to exclude board.c from the SPL? Or
do i misinterpret something? Also cache.c I would include to a
standard SPL.

I really like the new SPL - good work! ;)

Regards
Simon