[U-Boot] SPL framework re-design

V, Aneesh
2011-06-19T10:22:29Z

On Sat, Jun 18, 2011 at 3:58 AM, Scott Wood <scottwood@freescale.com> wrote:
> On Fri, 17 Jun 2011 22:18:57 +0530
> Aneesh V <aneesh@ti.com> wrote:
>
>> @@ -1158,6 +1164,7 @@ clobber: ? ? ? ?clean
>> ? ? ? @[ ! -d $(obj)nand_spl ] || find $(obj)nand_spl -name "*" -type l
>> -print | xargs rm -f
>> ? ? ? @[ ! -d $(obj)onenand_ipl ] || find $(obj)onenand_ipl -name "*" -type
>> l -print | xargs rm -f
>> ? ? ? @[ ! -d $(obj)mmc_spl ] || find $(obj)mmc_spl -name "*" -type l
>> -print | xargs rm -f
>> + ? ? @[ ! -d $(obj)spl ] || find $(obj)mmc_spl -name "*" -type l -print |
>> xargs rm -f
>
> That last mmc_spl should just be spl.
>
>> +LIBS-$(CONFIG_SYS_SPL_NAND_SUPPORT) += mmc/libnand.o
>> +LIBS-$(CONFIG_SYS_SPL_ONENAND_SUPPORT) += mmc/libonenand.o

Oops!! That was a copy paste error. It was intended to be:
+LIBS-$(CONFIG_SYS_SPL_NAND_SUPPORT) += nand/libnand.o
+LIBS-$(CONFIG_SYS_SPL_ONENAND_SUPPORT) += onenand/libonenand.o

>
> Why are these in mmc?
>
> What is it you propose would be in these files?
>
>> +$(LIBS-y): ? depend
>> + ? ? ? ? ? ? $(MAKE) -C $(dir $(subst $(obj),,$@)) all
>
> If no libraries are selected, this will produce a rule with an empty
> target, which is undefined behavior.

The top-level Makefile doesn't include any source files by itself.
All SPL content comes from one or more of libraries. So, there
will be at least one library defined, I believe(unless there
is an error, of course).

>
> -Scott
>
>