[U-Boot] [RFC PATCH v2 2/9] spl: add initial support for a generic SPL framework

Daniel Schwierzeck
2011-07-18T16:22:39Z

Dear Wolfgang,

sorry, I sent the new series too early and missed your answer.
I'll address your comments.

On Mon, Jul 18, 2011 at 6:06 PM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Daniel Schwierzeck,
>
> In message <1310746944-32711-1-git-send-email-daniel.schwierzeck@googlemail.com> you wrote:
>> Signed-off-by: Aneesh V <aneesh@ti.com>
>> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@googlemail.com>
>
> Thanks.
>
>> +Overview
>> +--------
>> +
>> +To unify all existing implementations for a secondary program loader (SPL)
>> +and to allow simply adding of new implementations this generic SPL framework
>> +have been created. With this framework almost all source files for a board
>
> s/have/has/
>
>> +How it works
>> +------------
>> +
>> +There is a new directory TOPDIR/spl which contains only a Makefile.
>> +All source files needed by SPL are recompiled inside this directory
>> +and linked to the final binaries named u-boot-spl[.bin|.map].
>
> The "recompiled inside this directory" might be misinterpreted. ?How
> about: "are compiled such that the resulting object files are placed
> into this directory" or similar?
>
>> +Thus makefiles and source files are able to build things differently for SPL.
>
> Strictly speaking, the source files don't build anything themself.How
> about: "This way we can compile the source files with different
> settings for SPL." ?
>
>> +Because SPL images normally have a different test base, one have to be
>
> s/test/text/
>
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Marriage is the sole cause of divorce.
>