[U-Boot] [RFC PATCH 6/7] omap: common spl support for OMAP3/4

Heiko Schocher
2011-06-30T07:53:09Z

Hello Aneesh,

Aneesh V wrote:
> On Thursday 30 June 2011 11:31 AM, Heiko Schocher wrote:
>> Hello Aneesh,
>>
>> Aneesh V wrote:
>>> Signed-off-by: Aneesh V<aneesh@ti.com>
>>> ---
>>> arch/arm/cpu/armv7/omap-common/Makefile | 9 ++--
>>> arch/arm/cpu/armv7/omap-common/spl.c | 56
>>> ++++++++++++++++++++++++++++
>>> arch/arm/cpu/armv7/omap-common/spl.lds | 62
>>> +++++++++++++++++++++++++++++++
>>> 3 files changed, 123 insertions(+), 4 deletions(-)
>>> create mode 100644 arch/arm/cpu/armv7/omap-common/spl.c
>>> create mode 100644 arch/arm/cpu/armv7/omap-common/spl.lds
>>>
>> [...]
>>> diff --git a/arch/arm/cpu/armv7/omap-common/spl.c
>>> b/arch/arm/cpu/armv7/omap-common/spl.c
>>> new file mode 100644
>>> index 0000000..b5a5f3c
>>> --- /dev/null
>>> +++ b/arch/arm/cpu/armv7/omap-common/spl.c
>> [...]
[...]
>>
>> BTW: Do you really need to relocate code? You could just load the 2nd
>> stage loader to ram from board_init_f, or?
>
> I am passing the same address as I am executing from as the target for
> the relocation, so the relocation will not happen, instead BSS will be
> initialized. That's what I am calling it for. Initially I had my own
> routine for clearing BSS. Then I decided to re-use it from start.S

Ah, I see! Maybe you can add a comment here?
Thanks!

Hmm, I actually porting a dm368 based board with nand_spl support
(patches following soon), and there I have an empty bss section,
so I can direct copy the u-boot image from nand to ram in board_init_f().

> BTW, this series is not complete as far as SPL support is concerned.
> It doesn't even build due to many undefined references. It serves only
> as a prototype for the framework part.

Ah, Ok ...

bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany