[U-Boot] [RFC PATCH 6/7] omap: common spl support for OMAP3/4

Aneesh V
2011-06-30T11:18:45Z

On Thursday 30 June 2011 04:39 PM, Albert ARIBAUD wrote:
> Hi Simon,
>
> Le 30/06/2011 10:21, Simon Schwarz a ?crit :
>> Hi,
>>
>>> Hmm, I actually porting a dm368 based board with nand_spl support
>>> (patches following soon), and there I have an empty bss section,
>>> so I can direct copy the u-boot image from nand to ram in board_init_f().
>>
>> This is what I'am doing with OMAP3 also. IMHO it would be more
>> readable if relocate_code is not called if there is no relocation and
>> instead the clear_bss()-function is used as Andreas suggested. (Or to
>> just not use clear_bss if bss is empty)
>
> IMO, for the sake of rpbustness, the clear_bss code should handle the
> case where the BSS is empty, and for the sake of simplicity, it should
> be called always.

I shall check the case when BSS is empty and fix it if needed.

br,
Aneesh