[U-Boot] [RFC PATCH 1/4] Adapt config.mk for usage in spl/Makefile

Wolfgang Denk
2011-07-08T11:19:00Z

Dear Aneesh V,

In message <4E16D9DA.4080803@ti.com> you wrote:
>
> >> +CONFIG_NORMAL_UBOOT = $(if $(CONFIG_UBOOT_SPL_BUILD),,y)
> >
> > Is this not redundant, then?
>
> Yes, it is. But it was handy for conditional inclusion of source files
> in the Makefiles, like this:
>
> +# used only by normal u-boot
> +COBJS-$(CONFIG_NORMAL_UBOOT) += fileA.o
> +# used only by SPL
> +COBJS-$(CONFIG_UBOOT_SPL_BUILD) += fileB.o
> +# used by SPL and normal u-boot
> +COBJS-y += fileC.o
>
> Without CONFIG_NORMAL_UBOOT this becomes a little cumbersome.

Hm... instead of

COBJS-$(CONFIG_NORMAL_UBOOT) += fileA.o

we could use

COBJS-$(if $(CONFIG_UBOOT_SPL_BUILD),,y)

directly.

Note that Daniel's patches never referenced CONFIG_NORMAL_UBOOT
anywhere, so I think we can remove it for now and decide when it
turns out we really need it.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
: 1. What is the possibility of this being added in the future?
In the near future, the probability is close to zero. In the distant
future, I'll be dead, and posterity can do whatever they like... :-)
- lwall