From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aneesh V Date: Fri, 08 Jul 2011 17:10:38 +0530 Subject: [U-Boot] [RFC PATCH 1/4] Adapt config.mk for usage in spl/Makefile In-Reply-To: <20110708111900.24DFF126F38F@gemini.denx.de> References: <1309352967-5719-1-git-send-email-aneesh@ti.com> <1309883182-12854-1-git-send-email-daniel.schwierzeck@googlemail.com> <1309883182-12854-2-git-send-email-daniel.schwierzeck@googlemail.com> <20110708090838.E92A9126F38F@gemini.denx.de> <4E16D9DA.4080803@ti.com> <20110708111900.24DFF126F38F@gemini.denx.de> Message-ID: <4E16ECB6.5070402@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 08 July 2011 04:49 PM, Wolfgang Denk wrote: > Dear Aneesh V, > > In message<4E16D9DA.4080803@ti.com> you wrote: >> >>>> +CONFIG_NORMAL_UBOOT = $(if $(CONFIG_UBOOT_SPL_BUILD),,y) >>> >>> Is this not redundant, then? >> >> Yes, it is. But it was handy for conditional inclusion of source files >> in the Makefiles, like this: >> >> +# used only by normal u-boot >> +COBJS-$(CONFIG_NORMAL_UBOOT) += fileA.o >> +# used only by SPL >> +COBJS-$(CONFIG_UBOOT_SPL_BUILD) += fileB.o >> +# used by SPL and normal u-boot >> +COBJS-y += fileC.o >> >> Without CONFIG_NORMAL_UBOOT this becomes a little cumbersome. > > Hm... instead of > > COBJS-$(CONFIG_NORMAL_UBOOT) += fileA.o > > we could use > > COBJS-$(if $(CONFIG_UBOOT_SPL_BUILD),,y) This is what I was trying to avoid. Isn't the above more obvious for lay-users of make? best regards, Aneesh