From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Sat, 09 Jul 2011 08:52:56 +0200 Subject: [U-Boot] [PATCH v2] scb9328: Add ARM relocation support In-Reply-To: <4E119EBE.7020102@synertronixx.de> References: <4E119EBE.7020102@synertronixx.de> Message-ID: <4E17FAC8.4020702@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/04/2011 01:06 PM, Torsten Koschorrek wrote: > This patch fixes compiler errors due to missing definitions of > CONFIG_SYS_SDRAM_BASE and CONFIG_SYS_INIT_SP_ADDR. > It also does some cleanup: CONFIG_SYS_TEXT_BASE was moved to scb9328.h, > obsolete config.mk was removed. The scb9328 board has 1 DRAM bank, so don't > ask for more banks. CONFIG_NR_DRAM_BANKS will ever be 1. > > Signed-off-by: Torsten Koschorrek > --- Torsten, checkpatch reports a couple of errors and your patch seems corrupted. Have you used "git send-email" to post your patch ? WARNING: space prohibited between function name and open parenthesis '(' #60: FILE: board/scb9328/scb9328.c:48: +void dram_init_banksize (void) ERROR: patch seems to be corrupt (line wrapped?) #80: FILE: board/scb9328/scb9328.c:53: diff --git a/include/configs/scb9328.h b/include/configs/scb9328.h ERROR: Macros with complex values should be enclosed in parenthesis #90: FILE: board/scb9328/scb9328.c:131: +#define CONFIG_SYS_INIT_SP_ADDR SCB9328_SDRAM_1 + 0xf00000 total: 2 errors, 2 warnings, 46 lines checked Can you fix them and repost ? > +#define CONFIG_SYS_INIT_SP_ADDR SCB9328_SDRAM_1 + 0xf00000 You must add parenthesis surrounding the values. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================