public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Graeme Russ <graeme.russ@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] scb9328: Add ARM relocation support
Date: Sun, 10 Jul 2011 15:25:59 +1000	[thread overview]
Message-ID: <4E1937E7.4030608@gmail.com> (raw)
In-Reply-To: <4E187567.5020804@synertronixx.de>

Hi Torsten,

On 10/07/11 01:36, Torsten Koschorrek wrote:
> Stefano Babic wrote:
>> On 07/04/2011 01:06 PM, Torsten Koschorrek wrote:
>>> This patch fixes compiler errors due to missing definitions of
>>> CONFIG_SYS_SDRAM_BASE and CONFIG_SYS_INIT_SP_ADDR.
>>> It also does some cleanup: CONFIG_SYS_TEXT_BASE was moved to scb9328.h,
>>> obsolete config.mk was removed. The scb9328 board has 1 DRAM bank, so don't
>>> ask for more banks. CONFIG_NR_DRAM_BANKS will ever be 1.
>>>
>>> Signed-off-by: Torsten Koschorrek<koschorrek@synertronixx.de>
>>> ---
>>
>> Torsten,
>>
>> checkpatch reports a couple of errors and your patch seems corrupted.
>> Have you used "git send-email" to post your patch ?
> 
> I used git format-patch plus mozilla/iceape. Hmm, maybe I choose another 
> mailer for sending patches the next time...
> 

use git send-email - trust me, this will save you a heap of pain :)

Regards,

Graeme

      reply	other threads:[~2011-07-10  5:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-04 11:06 [U-Boot] [PATCH v2] scb9328: Add ARM relocation support Torsten Koschorrek
2011-07-09  6:52 ` Stefano Babic
2011-07-09 15:36   ` Torsten Koschorrek
2011-07-10  5:25     ` Graeme Russ [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1937E7.4030608@gmail.com \
    --to=graeme.russ@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox