public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vitaly Kuzmichev <vkuzmichev@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation
Date: Wed, 13 Jul 2011 18:43:29 +0400	[thread overview]
Message-ID: <4E1DAF11.1040408@mvista.com> (raw)
In-Reply-To: <1310567392-29082-2-git-send-email-l.majewski@samsung.com>

Hi Lukasz,

On 07/13/2011 06:29 PM, Lukasz Majewski wrote:
> This commit provides UDC driver support for Samsung's SoC
> family of processors.
> 
[...]
> diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile
> index 7d5b504..6717e4f 100644
> --- a/drivers/usb/gadget/Makefile
> +++ b/drivers/usb/gadget/Makefile
> @@ -26,9 +26,9 @@ include $(TOPDIR)/config.mk
>  LIB	:= $(obj)libusb_gadget.o
>  
>  # new USB gadget layer dependencies
> -ifdef CONFIG_USB_ETHER
> -COBJS-y += ether.o epautoconf.o config.o usbstring.o
> -COBJS-$(CONFIG_USB_ETH_RNDIS) += rndis.o
> +ifdef CONFIG_USB_GADGET
> +COBJS-y += epautoconf.o config.o usbstring.o
> +COBJS-$(CONFIG_USB_GADGET_S3C_UDC_OTG) += s3c_udc_otg.o
>  else
>  # Devices not related to the new gadget layer depend on CONFIG_USB_DEVICE
>  ifdef CONFIG_USB_DEVICE

You're completely removing support of Ethernet and RNDIS gadgets.
This is unacceptable.

  reply	other threads:[~2011-07-13 14:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-13 14:29 [U-Boot] [PATCH v2 0/5] usb:gadget USB Gadget support Lukasz Majewski
2011-07-13 14:29 ` [U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation Lukasz Majewski
2011-07-13 14:43   ` Vitaly Kuzmichev [this message]
2011-07-14  8:14   ` [U-Boot] [RESEND PATCH " Lukasz Majewski
2011-10-06 22:10   ` [U-Boot] [PATCH " Wolfgang Denk
2011-10-07  7:39     ` Lukasz Majewski
2011-10-09 19:43       ` Wolfgang Denk
2011-10-10 20:00         ` Scott Wood
2011-10-10 20:38           ` Wolfgang Denk
2011-10-10 20:55             ` Scott Wood
2011-10-10 21:54               ` Wolfgang Denk
2011-10-10 22:00                 ` Scott Wood
2011-07-13 14:29 ` [U-Boot] [PATCH v2 2/5] usb:gadget:s5p Enabling the USB Gadget framework at GONI Lukasz Majewski
2011-07-13 14:29 ` [U-Boot] [PATCH v2 3/5] usb:gadget: USB Mass Storage - files from Linux kernel Lukasz Majewski
2011-10-06 22:10   ` Wolfgang Denk
2011-10-07  7:28     ` Lukasz Majewski
2011-10-07  8:25       ` Wolfgang Denk
2011-07-13 14:29 ` [U-Boot] [PATCH v2 4/5] usb:gadget: USB Mass Storage Gadget support Lukasz Majewski
2011-07-13 14:29 ` [U-Boot] [PATCH v2 5/5] usb:gadget:s5p Support for USB Mass Storage Gadget on GONI Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1DAF11.1040408@mvista.com \
    --to=vkuzmichev@mvista.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox