From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Thu, 14 Jul 2011 10:58:30 +0200
Subject: [U-Boot] [PATCH] I2C: mxc_i2c rework
In-Reply-To: <4E1DA41D.8080505@denx.de>
References: <1310550794-27795-1-git-send-email-marek.vasut@gmail.com>
	<4E1DA41D.8080505@denx.de>
Message-ID: <4E1EAFB6.6070000@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Stefano,

Stefano Babic wrote:
> On 07/13/2011 11:53 AM, Marek Vasut wrote:
>> Rewrite the mxc_i2c driver.
>>  * This version is much closer to Linux implementation.
>>  * Fixes IPG_PERCLK being incorrectly used as clock source
>>  * Fixes behaviour of the driver on iMX51
>>  * Clean up coding style a bit ;-)
>>
>> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
>> ---
> 
> Hi Marek,
> 
> I have added Heiko in CC. He is the Maintainer for I2C.

Thanks! ;-)

[...]
>> +/*
>> + * Write register address
>> + */
>> +int i2c_imx_set_reg_addr(uint addr, int alen)
>>  {
>> -	int i, retry = 0;
>> -	for (retry = 0; retry < 3; retry++) {
>> -		if (wait_idle())
>> +	int ret;
>> +	int i;
>> +
> 
> mmmhh...it seems to me you change completely the logic here. Heiko, waht
> do you think about ?

I think this is OK, because of calling i2c_imx_trx_complete() later,
which do this ...

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany