From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Thu, 14 Jul 2011 14:39:51 +0200 Subject: [U-Boot] [PATCH] ARM: MX5: Fix broken leftover TO-2 errata workaround In-Reply-To: <20110714143002.28eb3dc2@archvile> References: <1310644580-1005-1-git-send-email-david@protonic.nl> <4E1EDDBC.4010109@denx.de> <20110714143002.28eb3dc2@archvile> Message-ID: <4E1EE397.1030205@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/14/2011 02:30 PM, David Jander wrote: >> You have to protect the code related to TO2 with CONFIG_MX51. As I can >> see, the macro is called for MX.53, too, and the test produces wrong >> results. > > Wow, you are right! So this code was actually broken in more ways than I > initially thought :-) Yes, with one shot you hit more bugs... > Ok, will fix it (again). > Btw, may I congratulate you for your good work in improving u-boot code > quality? It is starting to get to a level only known from LKML ;-) Congratulations go to all participants and reviewers of this ML, who are helping to improve the quality of the code ;-) > Clearly the code was not reviewed as well when this was initially submitted. That is right - some issues was not seen and not fixed in time. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================