From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Thu, 14 Jul 2011 15:49:23 +0200 Subject: [U-Boot] [PATCH] miiphy: use strcpy() not sprintf() In-Reply-To: <1310646667-2426-1-git-send-email-lwithers@guralp.com> References: <1310646667-2426-1-git-send-email-lwithers@guralp.com> Message-ID: <4E1EF3E3.8090600@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Laurence, Le 14/07/2011 14:31, Laurence Withers a ?crit : > In miiphy_register() the new device's name was initialised by passing a > string parameter as the format string to sprintf(). As this would cause > problems if it ever contained a '%' symbol, switch to using strcpy() > instead. Please use strncpy() which will also guard against overflows. Amicalement, -- Albert.