[U-Boot] [PATCH 1/2] arm, lib/board.c: Coding Style cleanup

馬克泡
2011-07-15T00:17:26Z

Hi Heiko and Albert,

2011/7/15 Albert ARIBAUD <albert.u.boot@aribaud.net>
>
> Hi Heiko,
>
> Sorry for having kept this patch unanswered so long. I am now on
> holiday, which means *a bit* more time for U-Boot, so here comes:
>
> Re: patch title, can you make it "arm: libboard.c: ..." rather than
> "arm, libboard.c" ?

Just remind both of you here, about the clean up patches,
we have an other prefix for the patch title (subject).

http://www.denx.de/wiki/U-Boot/Patches
General Patch Submission Rules

"Non-functional changes, i.e. whitespace and reformatting changes,
should be done in separate patches marked as cosmetic. This separation
of functional and cosmetic changes greatly facilitates the review
process."

So, please use "cosmetic:" as the beginning prefix of your clear up patch.

>
> Also, make sure you rebase onto latest u-boot-arm/master for next
> version: this one does not apply cleanly ATM.

[deleted]

>
> > - ? ? ? ? ? ? ? ? ? ? printf (" ?CRC: %08X",
> > - ? ? ? ? ? ? ? ? ? ? ? ? ? ? crc32 (0, (const unsigned char *) CONFIG_SYS_FLASH_BASE, flash_size)
> > + ? ? ? ? ? ? ? ? ? ? printf(" ?CRC: %08X",
> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? crc32(0,
> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? (const unsigned char *) CONFIG_SYS_FLASH_BASE,
> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? flash_size)
>
> Pleas indent deeper for the last two lines that belong to the call to crc32.
>
> Amicalement,

--
Best regards,
Macpaul Lin