public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] armv7: fix: Disable D cache for goni target (s5p)
Date: Sat, 16 Jul 2011 11:33:19 +0200	[thread overview]
Message-ID: <4E215ADF.9070805@aribaud.net> (raw)
In-Reply-To: <20110715093451.30e341a0@lmajewski.digital.local>

Hi Lukasz,

Le 15/07/2011 09:34, Lukasz Majewski a ?crit :
> On Thu, 14 Jul 2011 16:00:23 +0200
> Albert ARIBAUD<albert.u.boot@aribaud.net>  wrote:
>
>> Hi Lukasz,
>>
>> Le 11/07/2011 09:41, Lukasz Majewski a ?crit :
>>> Signed-off-by: Lukasz Majewski<l.majewski@samsung.com>
>>> Cc: Minkyu Kang<mk7.kang@samsung.com>
>>> Cc: Aneesh V<aneesh@ti.com>
>>> ---
>>
>> Can you please submit a V2 patch in which the commit message provides
>> a rationale for turning the data cache off? People who want to turn
>> it on later will benefit from the info.
>>
>> Amicalement,
>
> Hi Albert,
>
> Rationale for turning OFF D cache:
>
> 1. Before change introduced in commit
> SHA1:c2dd0d45540397704de9b13287417d21049d34c6 the D-cache for
> GONI/Universal_c210 targets was disabled. This change was supposed to
> preserve this state.
>
> 2. I've done some investigation about enabling D-cache support. It
> turned out, that some drivers (which are already posted or are in the
> queue for posting to u-boot list) have had problems with D-cache
> coherency.
>
> This commit shall be treated as a temporal solution. After solving
> cache management (and coherency) problems the D-cache would be
> definitely enabled.

Thanks. Except for a typo (Temporal-> Temporary), please put this 
rationale in the commit message for V2.

Amicalement,
-- 
Albert.

      reply	other threads:[~2011-07-16  9:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11  7:41 [U-Boot] armv7: fix: Disable D cache for goni target (s5p) Lukasz Majewski
2011-07-14 14:00 ` Albert ARIBAUD
2011-07-15  7:34   ` Lukasz Majewski
2011-07-16  9:33     ` Albert ARIBAUD [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E215ADF.9070805@aribaud.net \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox