From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Sat, 16 Jul 2011 11:33:19 +0200
Subject: [U-Boot] armv7: fix: Disable D cache for goni target (s5p)
In-Reply-To: <20110715093451.30e341a0@lmajewski.digital.local>
References: <1310370069-20901-1-git-send-email-l.majewski@samsung.com>
	<4E1EF677.1080902@aribaud.net>
	<20110715093451.30e341a0@lmajewski.digital.local>
Message-ID: <4E215ADF.9070805@aribaud.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Lukasz,

Le 15/07/2011 09:34, Lukasz Majewski a ?crit :
> On Thu, 14 Jul 2011 16:00:23 +0200
> Albert ARIBAUD<albert.u.boot@aribaud.net>  wrote:
>
>> Hi Lukasz,
>>
>> Le 11/07/2011 09:41, Lukasz Majewski a ?crit :
>>> Signed-off-by: Lukasz Majewski<l.majewski@samsung.com>
>>> Cc: Minkyu Kang<mk7.kang@samsung.com>
>>> Cc: Aneesh V<aneesh@ti.com>
>>> ---
>>
>> Can you please submit a V2 patch in which the commit message provides
>> a rationale for turning the data cache off? People who want to turn
>> it on later will benefit from the info.
>>
>> Amicalement,
>
> Hi Albert,
>
> Rationale for turning OFF D cache:
>
> 1. Before change introduced in commit
> SHA1:c2dd0d45540397704de9b13287417d21049d34c6 the D-cache for
> GONI/Universal_c210 targets was disabled. This change was supposed to
> preserve this state.
>
> 2. I've done some investigation about enabling D-cache support. It
> turned out, that some drivers (which are already posted or are in the
> queue for posting to u-boot list) have had problems with D-cache
> coherency.
>
> This commit shall be treated as a temporal solution. After solving
> cache management (and coherency) problems the D-cache would be
> definitely enabled.

Thanks. Except for a typo (Temporal-> Temporary), please put this 
rationale in the commit message for V2.

Amicalement,
-- 
Albert.