[U-Boot] [PATCH V2 2/4] Don't compile in large memory test function by default.

Wolfgang Denk
2011-08-04T10:20:52Z

Dear Christopher Harvey,

In message <20110707143109.GC5438@harvey-pc.matrox.com> you wrote:
>
> I didn't receive comments on this one. By not compiling this by
> default it removes a couple of #defines people need to think
> about. Also, I'm guessing the memory test isn't used very much, so
> this makes u-boot a bit smaller.
>
> common/cmd_mem.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/common/cmd_mem.c b/common/cmd_mem.c
> index a5576aa..833af66 100644
> --- a/common/cmd_mem.c
> +++ b/common/cmd_mem.c
> @@ -610,6 +610,8 @@ int do_mem_loopw (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> }
> #endif /* CONFIG_LOOPW */
>
> +#ifdef CONFIG_CMD_MTEST

Formal complaint: ifh you introduce new CONFIG_ options, you MUST
document these in the README.

What is worse is that your commit changes global behaviour of U-Boot
for all architectures, nearly all boards.

Even if you guess that some feature might not be used we cannot simply
remove it lightly.

If you want to make this configurable, then as an opt-out, but not
mandatory for everybody.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If only God would give me some clear sign! Like making a large depo-
sit in my name at a Swiss Bank. - Woody Allen