[U-Boot] [PATCH V2 2/4] Don't compile in large memory test function by default.

Wolfgang Denk
2011-08-04T10:14:37Z

Dear Albert ARIBAUD,

In message <4E3A3CB8.2030703@aribaud.net> you wrote:
>
> > I didn't receive comments on this one. By not compiling this by
> > default it removes a couple of #defines people need to think
> > about. Also, I'm guessing the memory test isn't used very much, so
> > this makes u-boot a bit smaller.
...
> > common/cmd_mem.c | 5 +++++
> > 1 files changed, 5 insertions(+), 0 deletions(-)
...
> Applied to u-boot-arm/master, thanks!

Argh..

This is NOT an ARM specific patch.

Even worse, it changes global behaviour for most baords. This cannot
be dones easily.

Sorry, but NAK.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What is wanted is not the will to believe, but the will to find out,
which is the exact opposite.
-- Bertrand Russell, "Skeptical Essays", 1928