From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Sun, 17 Jul 2011 11:18:56 +0200 Subject: [U-Boot] [PATCH] Fix: if using crc32 command watchdog timed out In-Reply-To: <4E22805D.1010408@scharsoft.de> References: <4E12BC93.1000108@bus-elektronik.de> <4E215FA2.6030007@aribaud.net> <4E22805D.1010408@scharsoft.de> Message-ID: <4E22A900.8060705@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Jens, Le 17/07/2011 08:25, Jens Scharsig a ?crit : > Hello, > Am 2011-07-16 11:53, schrieb Albert ARIBAUD: >> Hi Jens, >> >> Le 05/07/2011 09:26, Jens Scharsig a ?crit : >> >>> * Fix: if using crc32 command watchdog timed out >>> >>> >>> Signed-off-by: Jens Scharsig >>> --- >> >> Nitpick: in addition to describing which issue the patch fixes, can you >> describe how it fixes it? > > If your board is using a watchdog and you try to calculate/check a CRC2 > with crc32 command, the watchdog timed out on large data blocks. > The commands around uboot-images also uses crc32, but don't time out. > The difference between: > > CRC32 command calls the the crc32 function and the"image" commands > crc32_wd (i think _wd stands for watchdog). So this patch changes the > the function call from crc32 to crc_32 to support watchdog reset in the > same way as "image" commands. Sorry, I meant: describe what the fix does in the commit message, not on the list. Generally, a patch commit message should always describe what the patch does. > Best regards > > Jens Amicalement, -- Albert.