From mboxrd@z Thu Jan 1 00:00:00 1970 From: Holger Brunck Date: Mon, 18 Jul 2011 11:41:28 +0200 Subject: [U-Boot] [PATCH 2/2] arm/km: fix u-boot.kwb build breakage In-Reply-To: <4E216D43.4050107@aribaud.net> References: <4DF86191.4020104@keymile.com> <4E216D43.4050107@aribaud.net> Message-ID: <4E23FFC8.8070009@keymile.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Albert, On 07/16/2011 12:51 PM, Albert ARIBAUD wrote: > Le 15/06/2011 09:38, Holger Brunck a ?crit : > >> I agree for a single board support, but this is not possible in our approach. We >> include config_cmd_default.h in keymile-common.h. And keymile-common.h is valid >> for our powerpc and arm boards. In km_arm.h we add the CMD settings which are >> only additionaly needed on our arm boards. > > You can #undef things just as you can #define them after including default > command headers -- I personally see no issue with this. > yes you are right it could be done this way. But I think it's more clearly arranged if we only define the commands in keymile-common.h wich are common for all keymile boards rather to define a superset there and undef them later on in km-powerpc.h or km_arm.h. Best regards Holger Brunck