From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Tue, 19 Jul 2011 10:23:21 +0200 Subject: [U-Boot] [PATCH 3/4] Armada100: Enable 88E3015 PHY support for GplugD In-Reply-To: <689858104.27342.1311048656182.JavaMail.root@ahm.einfochips.com> References: <689858104.27342.1311048656182.JavaMail.root@ahm.einfochips.com> Message-ID: <4E253EF9.7040907@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Ajay, Le 19/07/2011 06:10, Ajay Bhargav a ?crit : >>> + gpio_set_value(CONFIG_SYS_GPIO_PHY_RST, GPIO_SET); >> >> May you please comment why do you need to set this GPIO? > > GPIO 104 is connected to reset pin of 88E3015 PHY. and a reset is > required before initializing PHY chip. I believe Prafulla would like this comment to appear in the code -- anyway, *I* would like it to. :) > Regards, > Ajay Bhargav Amicalement, -- Albert.