From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aneesh V Date: Thu, 28 Jul 2011 12:57:40 +0530 Subject: [U-Boot] [PATCH V4 3/5] nand spl: add NAND Library to new SPL In-Reply-To: <20110727170129.5e5fc5e3@schlenkerla.am.freescale.net> References: <1311675739-10966-1-git-send-email-simonschwarzcor@gmail.com> <1311682158-15150-1-git-send-email-simonschwarzcor@gmail.com> <1311682158-15150-4-git-send-email-simonschwarzcor@gmail.com> <20110726130401.19abc73a@schlenkerla.am.freescale.net> <4E2FD8C7.3080402@gmail.com> <20110727170129.5e5fc5e3@schlenkerla.am.freescale.net> Message-ID: <4E310F6C.2050305@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Scott, On Thursday 28 July 2011 03:31 AM, Scott Wood wrote: > On Wed, 27 Jul 2011 20:25:44 +0530 > "V, Aneesh" wrote: > >> Hi Simon, Scott, >> >> On Wed, Jul 27, 2011 at 2:52 PM, Simon Schwarz >> wrote: >>> Dear Scott Wood, >>> >>> On 07/26/2011 08:04 PM, Scott Wood wrote: >>>> You're assuming all NAND SPLs will want nand_ecc -- this will not fit in >>>> most current ones. >>> >>> True. I changed it to: >>> ifdef CONFIG_SPL_BUILD >>> COBJS-y += nand_spl.o >>> ifdef CONFIG_OMAP34XX >> >> -ffunction-sections, -fdata-sections and --gc-sections are enabled globally >> for SPL. Source files are #ifdef'ed out in Makefile's for SPL primarily to >> reduce build time. > > Ah, right. > >> I would suggest to enable the super set of all files needed for all SPL's >> in these Makefile's and not clutter it with any more #ifdef's > > It's not relevant for nand_ecc, but there will still be a cases where > we'll want to select particular object files because we're selecting from > alternatives that provide the same symbols, or where an object file has > dependencies that are not met for this target. Agree. Perhaps those should only be the cases where we need additional 'ifdef's br, Aneesh