From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aneesh V Date: Thu, 28 Jul 2011 19:54:56 +0530 Subject: [U-Boot] [PATCH V6 2/5] omap-common: add nand spl support In-Reply-To: <4E3159B5.6090701@gmail.com> References: <1311771039-31691-1-git-send-email-simonschwarzcor@gmail.com> <1311842291-24837-1-git-send-email-simonschwarzcor@gmail.com> <1311842291-24837-3-git-send-email-simonschwarzcor@gmail.com> <4E312EFE.1080900@ti.com> <4E3159B5.6090701@gmail.com> Message-ID: <4E317138.5010804@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 28 July 2011 06:14 PM, Simon Schwarz wrote: [snip ..] >>> +#endif /* CONFIG_SPL_MMC_SUPPORT */ >> >> and here.. >> >> You start the same the #ifdef again immediately after the #endif. Why >> don't you club them together into just one #ifdef block. > IMHO #ifdef each function makes it more readable but... Ok. I don't have any strong views on that. > >> >> Actually, since we have garbage collection of un-used functions, I >> think doing the calls under #ifdef should be enough, which you have >> taken care in board_init_r(). That may help to avoid some #ifdef >> clutter. > ...I take this way :) > > I had to define some MMC specific stuff in the board config (copied it Does your board have MMC support? Then it definitely makes sense to keep MMC support enabled. > from OMAP4 - not tested) and added __attribute__((unused)) to > mmc_load_image to prevent the warning if the Library is not used. Did GCC give warning without this change? I think it doesn't due to -ffunction-sections? best regards, Aneesh