From: Simon Schwarz <simonschwarzcor@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V0] omap-common: move early UART clock setup to board.c
Date: Thu, 28 Jul 2011 16:53:00 +0200 [thread overview]
Message-ID: <4E3177CC.8030705@gmail.com> (raw)
In-Reply-To: <20110728130224.5A3DA15794D5@gemini.denx.de>
Dear Wolfgang Denk,
On 07/28/2011 03:02 PM, Wolfgang Denk wrote:
> Dear Simon Schwarz,
>
> In message<1311844938-17278-1-git-send-email-simonschwarzcor@gmail.com> you wrote:
>> This patch moves the setup_clocks_for_console()-call from
>> preloader_console_init() to s_init().
>> This is done to use the same implementation for OMAP3 and OMAP4
>>
>> For discussion see: http://article.gmane.org/gmane.comp.boot-loaders.u-boot/104120
>>
>> This is based on the following patches:
>> - New SPL framework
>> - OMAP4 SPL
>> Both are already in u-boot-ti repo.
>>
>> Simon Schwarz (1):
>> omap-common: move early UART clock setup to s_init
>>
>> arch/arm/cpu/armv7/omap-common/spl.c | 1 -
>> arch/arm/cpu/armv7/omap4/board.c | 1 +
>> 2 files changed, 1 insertions(+), 1 deletions(-)
>
> There is no patch in this file anywhere.
No cover-letter for patch series - bad idea - noted.
>
> Also, please omit the "V0" part in the subject, it makes no sense.
ok.
>
> Finally, please don't use the same subject for several changes.
>
> Best regards,
>
> Wolfgang Denk
>
Regards
Simon Schwarz
prev parent reply other threads:[~2011-07-28 14:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 9:22 [U-Boot] [PATCH V0] omap-common: move early UART clock setup to board.c Simon Schwarz
2011-07-28 9:22 ` [U-Boot] [PATCH V0] omap-common: move early UART clock setup to s_init Simon Schwarz
2011-07-28 9:44 ` Andreas Bießmann
2011-07-29 12:51 ` Simon Schwarz
2011-07-28 13:04 ` Wolfgang Denk
2011-07-28 14:49 ` Simon Schwarz
2011-07-28 13:02 ` [U-Boot] [PATCH V0] omap-common: move early UART clock setup to board.c Wolfgang Denk
2011-07-28 14:53 ` Simon Schwarz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3177CC.8030705@gmail.com \
--to=simonschwarzcor@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox