From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aneesh V <aneesh@ti.com>
Date: Fri, 29 Jul 2011 14:11:16 +0530
Subject: [U-Boot] [PATCH v4 02/12] omap4: cleanup pin mux data
In-Reply-To: <20110728192643.E616315794DB@gemini.denx.de>
References: <1298893591-17636-1-git-send-email-aneesh@ti.com>
	<1311233298-17265-3-git-send-email-aneesh@ti.com>
	<20110728192643.E616315794DB@gemini.denx.de>
Message-ID: <4E32722C.6020707@ti.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang,

On Friday 29 July 2011 12:56 AM, Wolfgang Denk wrote:
> Dear Aneesh V,
>
> In message<1311233298-17265-3-git-send-email-aneesh@ti.com>  you wrote:
>> - separate mux settings into essential and non essential parts
>> - essential part is board independent as of now(so move it
>>    to SoC directory). Will help in having single SPL for all
>>    boards.
>> - Non-essential part(the pins not essential for u-boot to function)
>>    need to be phased out eventually.
>> - Correct mux data by aligning to the latest settings in x-loader
> ...
>> +	{USBB1_ULPITLL_CLK, (IEN | OFF_EN | OFF_IN | M1)},		/* hsi1_cawake */
>> +	{USBB1_ULPITLL_STP, (IEN | OFF_EN | OFF_IN | M1)},		/* hsi1_cadata */
>> +	{USBB1_ULPITLL_DIR, (IEN | OFF_EN | OFF_IN | M1)},		/* hsi1_caflag */
>> +	{USBB1_ULPITLL_NXT, (OFF_EN | M1)},				/* hsi1_acready */
>> +	{USBB1_ULPITLL_DAT0, (OFF_EN | M1)},				/* hsi1_acwake */
>> +	{USBB1_ULPITLL_DAT1, (OFF_EN | M1)},				/* hsi1_acdata */
>> +	{USBB1_ULPITLL_DAT2, (OFF_EN | M1)},				/* hsi1_acflag */
>> +	{USBB1_ULPITLL_DAT3, (IEN | OFF_EN | OFF_IN | M1)},		/* hsi1_caready */
>
> Lines too long, please fix globally.

This table looks better and readable if each row is a single line. I
had mentioned this in the commit log. Does it make sense to make an
exception for this?

best regards,
Aneesh