From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 29 Jul 2011 11:42:54 +0200 Subject: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework In-Reply-To: <201107291135.34868.marek.vasut@gmail.com> References: <1310594283-19819-1-git-send-email-marek.vasut@gmail.com> <201107291135.34868.marek.vasut@gmail.com> Message-ID: <4E32809E.1000503@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/29/2011 11:35 AM, Marek Vasut wrote: >> >> why you change i2c clock from IPG_PERCLK to IPG_CLK? > > On MX51, PERCLK are those fast (680MHz) clock, that's not source of clock for > I2C. The IPG_CLK (they are 68.5MHz iirc) are source for the I2C. Also, I > discussed this with Stefano and we agreed this is likely a bug. Well, this code must be suitable for all i.MX processor. If we have a different source for i.MX51 and i.MX53, we can hide this adding an entry to mxc_get_clock(), such as mxc_get_clock(MXC_I2C_CLK). the right clock is then chosen in the specific mxc_get_clock function. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================