[U-Boot] [PATCH V0] omap-common: move early UART clock setup to s_init

[Simon Schwarz <simonschwarzcor@googlemail.com>]

Hi Andreas,

On 07/28/2011 11:44 AM, Andreas Bie?mann wrote:
> Hi Simon,
>
> Am 28.07.2011 11:22, schrieb Simon Schwarz:
>> Moves the early UART clock setup setup_clocks_for_console() from
>> preloader_console_init() to s_init() of OMAP4.
>
> I recommend putting this in your 'devkit8000 nand_spl support' series
> before the current '2/5 omap-common: add nand_spl support' and remove
> the '#ifdef CONFIG_OMAP34XX' in that patch. Albert how do you think
> about this?
>

Since no one objected: I will do this in the next version.

>> Signed-off-by: Simon Schwarz<simonschwarzcor@gmail.com>
>> ---
>>   arch/arm/cpu/armv7/omap-common/spl.c |    1 -
>>   arch/arm/cpu/armv7/omap4/board.c     |    1 +
>>   2 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/cpu/armv7/omap-common/spl.c b/arch/arm/cpu/armv7/omap-common/spl.c
>> index d177652..d380b3e 100644
>> --- a/arch/arm/cpu/armv7/omap-common/spl.c
>> +++ b/arch/arm/cpu/armv7/omap-common/spl.c
>> @@ -259,7 +259,6 @@ void preloader_console_init(void)
>
> I recommend adding some comment for preloader_console_init() saying
> 'this requires UART clocks to be enabled before' in this patch.

Will do.

>
>>   	gd->flags |= GD_FLG_RELOC;
>>   	gd->baudrate = CONFIG_BAUDRATE;
>>
>> -	setup_clocks_for_console();
>>   	serial_init();		/* serial communications setup */
>>
>>   	/* Avoid a second "U-Boot" coming from this string */
>
> regards
>
> Andreas Bie?mann

Regards
Simon