From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Sat, 30 Jul 2011 18:12:33 +0400 Subject: [U-Boot] [PATCH 3/3] cfb_console.c: checkpatch cleanup In-Reply-To: <1311969329-1109-4-git-send-email-wd@denx.de> References: <1311923413-62087-1-git-send-email-andreas.devel@googlemail.com> <1311969329-1109-1-git-send-email-wd@denx.de> <1311969329-1109-4-git-send-email-wd@denx.de> Message-ID: <4E341151.8080309@mvista.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello. On 29-07-2011 23:55, Wolfgang Denk wrote: > Fix the following: > ERROR: do not initialise statics to 0 or NULL > ERROR: do not use assignment in if condition > Signed-off-by: Wolfgang Denk > --- > drivers/video/cfb_console.c | 16 ++++++++++------ > 1 files changed, 10 insertions(+), 6 deletions(-) > diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c > index d2dd421..6e9143e 100644 > --- a/drivers/video/cfb_console.c > +++ b/drivers/video/cfb_console.c [...] > @@ -1648,7 +1651,8 @@ static int video_init(void) > { > unsigned char color8; > > - if ((pGD = video_hw_init()) == NULL) > + pGD = video_hw_init()) == ; Did you try to compile this? :-) WBR, Sergei