public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] ARM MX31: fix clock.h: warning: function declaration isn't a prototype
@ 2011-07-30 22:37 Wolfgang Denk
  2011-07-30 23:04 ` Fabio Estevam
  2011-07-31  9:05 ` Stefano Babic
  0 siblings, 2 replies; 4+ messages in thread
From: Wolfgang Denk @ 2011-07-30 22:37 UTC (permalink / raw)
  To: u-boot

Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Albert Aribaud <albert.aribaud@free.fr>
---
 arch/arm/include/asm/arch-mx31/clock.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/include/asm/arch-mx31/clock.h b/arch/arm/include/asm/arch-mx31/clock.h
index fb035c4..d4565ac 100644
--- a/arch/arm/include/asm/arch-mx31/clock.h
+++ b/arch/arm/include/asm/arch-mx31/clock.h
@@ -32,7 +32,7 @@ enum mxc_clock {
 };
 
 unsigned int mxc_get_clock(enum mxc_clock clk);
-extern u32 imx_get_uartclk();
+extern uint32_t imx_get_uartclk(void);
 extern void mx31_gpio_mux(unsigned long mode);
 extern void mx31_set_pad(enum iomux_pins pin, u32 config);
 
-- 
1.7.6

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] ARM MX31: fix clock.h: warning: function declaration isn't a prototype
  2011-07-30 22:37 [U-Boot] [PATCH] ARM MX31: fix clock.h: warning: function declaration isn't a prototype Wolfgang Denk
@ 2011-07-30 23:04 ` Fabio Estevam
  2011-07-30 23:35   ` Wolfgang Denk
  2011-07-31  9:05 ` Stefano Babic
  1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2011-07-30 23:04 UTC (permalink / raw)
  To: u-boot

Wolfgang,

On Sat, Jul 30, 2011 at 7:37 PM, Wolfgang Denk <wd@denx.de> wrote:
...
> ?unsigned int mxc_get_clock(enum mxc_clock clk);
> -extern u32 imx_get_uartclk();
> +extern uint32_t imx_get_uartclk(void);
> ?extern void mx31_gpio_mux(unsigned long mode);
> ?extern void mx31_set_pad(enum iomux_pins pin, u32 config);

Stefano has already addressed this issue:
http://www.mail-archive.com/u-boot at lists.denx.de/msg57483.html

Regards,

Fabio Estevam

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] ARM MX31: fix clock.h: warning: function declaration isn't a prototype
  2011-07-30 23:04 ` Fabio Estevam
@ 2011-07-30 23:35   ` Wolfgang Denk
  0 siblings, 0 replies; 4+ messages in thread
From: Wolfgang Denk @ 2011-07-30 23:35 UTC (permalink / raw)
  To: u-boot

Dear Fabio Estevam,

In message <CAOMZO5Br55A8YO9XVO=urGF_vS3KRtHT3ooJJCMuADrFGUZZmA@mail.gmail.com> you wrote:
> 
> Stefano has already addressed this issue:
> http://www.mail-archive.com/u-boot at lists.denx.de/msg57483.html

Argh.. wasted effort then.

Thanks for pointing out.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Vulcans believe peace should not depend on force.
	-- Amanda, "Journey to Babel", stardate 3842.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] ARM MX31: fix clock.h: warning: function declaration isn't a prototype
  2011-07-30 22:37 [U-Boot] [PATCH] ARM MX31: fix clock.h: warning: function declaration isn't a prototype Wolfgang Denk
  2011-07-30 23:04 ` Fabio Estevam
@ 2011-07-31  9:05 ` Stefano Babic
  1 sibling, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2011-07-31  9:05 UTC (permalink / raw)
  To: u-boot

On 07/31/2011 12:37 AM, Wolfgang Denk wrote:
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Albert Aribaud <albert.aribaud@free.fr>
> ---

Hi Wolfgang,

>  unsigned int mxc_get_clock(enum mxc_clock clk);
> -extern u32 imx_get_uartclk();
> +extern uint32_t imx_get_uartclk(void);
>  extern void mx31_gpio_mux(unsigned long mode);
>  extern void mx31_set_pad(enum iomux_pins pin, u32 config);

Thanks, but I have already sent the same patch a couple of days ago to
fix this issue ;-)

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-07-31  9:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-30 22:37 [U-Boot] [PATCH] ARM MX31: fix clock.h: warning: function declaration isn't a prototype Wolfgang Denk
2011-07-30 23:04 ` Fabio Estevam
2011-07-30 23:35   ` Wolfgang Denk
2011-07-31  9:05 ` Stefano Babic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox