[U-Boot] [PATCH 1/2] common: introduce a genutils.h file

Heiko Schocher
2011-01-10T07:09:05Z

Hello Wolfgang,

Wolfgang Denk wrote:
> In message <1292232393-26481-1-git-send-email-hs@denx.de> you wrote:
>> as discussed in thread
>> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/76654
>>
>> and as a result of this discussion Michael Zaidman
>> proposed to create a genutils.h, see:
>>
>> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/78692
>>
>> So, introduce this genutils.h, as BUILD_BUG_ON is also
>> needed in sensor support.
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> cc: Michael Zaidman <michael.zaidman@gmail.com>
>> ---
>> maybe I should include genutils.h in common.h ?
>>
>> include/genutils.h | 30 ++++++++++++++++++++++++++++++
>
> I do not like the idea of adding yet another nonstandard header file
> with just a few definitions in it.
>
> Linux defines this is include/linux/kernel.h, i. e. in a pretty
> central place, and we should porobably do the same.
>
> How about adding it to include/common.h instead?

Hmm.. I thought exactly this should not go in common.h as a
result from this thread:

http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/78692

bye,
Heiko