From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v 1/3] arm: do not force d-cache enable on all boards
Date: Tue, 02 Aug 2011 17:58:04 +0200 [thread overview]
Message-ID: <4E381E8C.1070901@aribaud.net> (raw)
In-Reply-To: <CAB4PhKcm+aXEPx-GGQntxER7pM-hz7yNda+kC4+_boj5RL14LQ@mail.gmail.com>
Le 02/08/2011 16:35, Jason Liu a ?crit :
> Hi, Albert,
>
> 2011/8/2 Albert ARIBAUD<albert.u.boot@aribaud.net>:
>> Hi Jason,
>>
>> Le 01/08/2011 18:33, Jason Liu a ?crit :
>>
>>> Maybe there will be many many duplicated code like this, do you wish that?
>>
>> I don't think this will or should be duplicated for each ARM board; more
>> like suplicated by SoC, or more precisely, by ARM implementation (i.e., one
>> cache handling for each of arch/arm/<architecture>/<implementation>) -- more
>> or less.
>
> Yes, not each ARM board, but should be a lot as the followings,
>
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 mx31
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 mx35
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 omap24xx
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 s3c64xx
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 tnetv107x
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-29 15:21 lpc2292
> drwxr-xr-x 2 r64343 r64343 4096 2011-04-13 13:00 s3c4510b
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 a320
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 at91rm9200
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 ep93xx
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 ks8695
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 s3c24x0
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 armada100
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 davinci
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 kirkwood
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 mb86r0x
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 mx25
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 mx27
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 nomadik
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 omap
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 orion5x
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 pantheon
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 spear
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 versatile
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-29 19:12 mx5
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-29 10:20 omap3
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-28 17:23 omap4
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 omap-common
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 10:46 s5pc1xx
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-26 17:37 s5pc2xx
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 s5p-common
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 tegra2
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 u8500
> drwxr-xr-x 3 r64343 r64343 4096 2011-07-29 15:21 npe
>
> All these arm/<architecture>/<implementation>s will have the duplicated code.
> can we consolidate it?
It might be (partially) possible to factorize some of the code from
implementations of the same <architecture> level (e.g., arm926ejs
architecture for orion5x, kirkwood, etc).
This will be something that developers (and reviewers) will need to keep
in mind when submitting patches that enable caches on ARM boards: such
code should be split across ARM architecture and implementation, so that
other implementations of the same arch will benefit from the common
architecture part.
> Jason
Amicalement,
--
Albert.
next prev parent reply other threads:[~2011-08-02 15:58 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 11:18 [U-Boot] [PATCH v 0/3] arm: changes in cache handling Aneesh V
2011-08-01 11:18 ` [U-Boot] [PATCH v 1/3] arm: do not force d-cache enable on all boards Aneesh V
2011-08-01 16:33 ` Jason Liu
2011-08-01 16:46 ` Jason Liu
2011-08-01 19:45 ` Wolfgang Denk
2011-08-01 19:53 ` Albert ARIBAUD
2011-08-02 14:35 ` Jason Liu
2011-08-02 15:58 ` Albert ARIBAUD [this message]
2011-08-05 15:07 ` Aneesh V
2011-08-07 6:20 ` Albert ARIBAUD
2011-08-09 11:10 ` [U-Boot] [PATCH 0/4] arm: changes in cache handling Aneesh V
2011-08-09 11:25 ` Aneesh V
2011-08-09 11:10 ` [U-Boot] [PATCH 1/4] arm: do not force d-cache enable on all boards Aneesh V
2011-08-09 11:10 ` [U-Boot] [PATCH 2/4] omap: enable caches at system start-up Aneesh V
2011-08-09 11:10 ` [U-Boot] [PATCH 3/4] armv7: stronger barrier for cache-maintenance operations Aneesh V
2011-08-09 11:10 ` [U-Boot] [PATCH 4/4] armv7: cache: remove flush on un-aligned invalidate Aneesh V
2011-08-09 16:39 ` Anton Staaf
2011-08-10 6:29 ` Albert ARIBAUD
2011-08-10 6:48 ` Aneesh V
2011-08-10 18:11 ` Anton Staaf
2011-08-11 6:29 ` Aneesh V
2011-08-09 11:34 ` [U-Boot] [PATCH v2 0/4] arm: changes in cache handling Aneesh V
2011-08-09 11:34 ` [U-Boot] [PATCH v2 1/4] arm: do not force d-cache enable on all boards Aneesh V
2011-08-09 14:41 ` [U-Boot] d-cache enable Lukasz Majewski
2011-08-12 10:59 ` Aneesh V
2011-08-12 11:41 ` Lukasz Majewski
2011-08-12 12:16 ` Aneesh V
2011-08-12 12:21 ` Albert ARIBAUD
2011-08-12 12:32 ` Reinhard Meyer
2011-08-12 12:36 ` Albert ARIBAUD
2011-08-12 13:08 ` Lukasz Majewski
2011-08-12 13:19 ` Albert ARIBAUD
2011-08-09 11:34 ` [U-Boot] [PATCH v2 2/4] omap: enable caches at system start-up Aneesh V
2011-08-09 11:34 ` [U-Boot] [PATCH v2 3/4] armv7: stronger barrier for cache-maintenance operations Aneesh V
2011-08-09 11:34 ` [U-Boot] [PATCH v2 4/4] armv7: cache: remove flush on un-aligned invalidate Aneesh V
2011-08-11 14:35 ` [U-Boot] [PATCH v3 0/4] arm: changes in cache handling Aneesh V
2011-08-13 10:09 ` Albert ARIBAUD
2011-08-15 7:40 ` V, Aneesh
2011-08-11 14:35 ` [U-Boot] [PATCH v3 1/4] arm: do not force d-cache enable on all boards Aneesh V
2011-08-14 11:09 ` Simon Guinot
2011-08-15 7:34 ` V, Aneesh
2011-08-16 14:33 ` [U-Boot] [PATCH v4 " Aneesh V
2011-08-11 14:35 ` [U-Boot] [PATCH v3 2/4] omap: enable caches at system start-up Aneesh V
2011-08-11 14:35 ` [U-Boot] [PATCH v3 3/4] armv7: stronger barrier for cache-maintenance operations Aneesh V
2011-08-11 14:35 ` [U-Boot] [PATCH v3 4/4] armv7: cache: remove flush on un-aligned invalidate Aneesh V
2011-08-01 11:18 ` [U-Boot] [PATCH v 2/3] omap: enable caches at system start-up Aneesh V
2011-08-01 11:18 ` [U-Boot] [PATCH v 3/3] armv7: stronger barrier for cache-maintenance operations Aneesh V
2011-08-05 10:29 ` [U-Boot] [PATCH v 0/3] arm: changes in cache handling Aneesh V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E381E8C.1070901@aribaud.net \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox