From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] mpc83xx: Add a GPIO driver for the MPC83XX family
Date: Tue, 9 Aug 2011 17:15:17 -0500 [thread overview]
Message-ID: <4E41B175.6080607@freescale.com> (raw)
In-Reply-To: <1312929090-29375-1-git-send-email-joe.hershberger@ni.com>
On 08/09/2011 05:31 PM, Joe Hershberger wrote:
> diff --git a/arch/powerpc/include/asm/arch-mpc83xx/gpio.h b/arch/powerpc/include/asm/arch-mpc83xx/gpio.h
> new file mode 100644
> index 0000000..4319d07
> --- /dev/null
> +++ b/arch/powerpc/include/asm/arch-mpc83xx/gpio.h
[snip
> +void gpio_init_f(void);
> +void gpio_init_r(void);
These are quite generic function names for 83xx to claim. If it's to be
part of the generic gpio API, why not add it to asm/gpio.h?
> @@ -140,6 +146,9 @@ void board_init_f(ulong bootflag)
>
> void board_init_r(gd_t *gd, ulong dest_addr)
> {
> +#if defined(CONFIG_MPC83XX_GPIO) && !defined(CONFIG_NAND_SPL)
> + gpio_init_r();
> +#endif
> nand_boot();
> }
This instance of board_init_r() is only for CONFIG_NAND_SPL, so this
won't do anything.
Maybe create a board_early_init_r() for this board?
-Scott
next prev parent reply other threads:[~2011-08-09 22:15 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 22:31 [U-Boot] [PATCH 1/2] mpc83xx: Add a GPIO driver for the MPC83XX family Joe Hershberger
2011-08-09 22:15 ` Scott Wood [this message]
2011-08-09 22:23 ` Joe Hershberger
2011-08-10 0:45 ` [U-Boot] [PATCH v3 " Joe Hershberger
2011-08-10 0:45 ` [U-Boot] [PATCH v3 2/2] mpc8313erdb: Enable GPIO support on the MPC8313E RDB Joe Hershberger
2011-08-09 22:31 ` [U-Boot] [PATCH " Joe Hershberger
2011-08-09 22:54 ` [U-Boot] [PATCH 1/2] mpc83xx: Add a GPIO driver for the MPC83XX family Kim Phillips
2011-08-09 23:03 ` Joe Hershberger
2011-08-10 4:56 ` [U-Boot] [PATCH v4 1/3] gpio: Move common gpio.h to include/asm-generic Joe Hershberger
2011-08-11 3:26 ` Mike Frysinger
2011-08-12 8:11 ` [U-Boot] [PATCH v5 " Joe Hershberger
2011-08-12 18:42 ` Mike Frysinger
2011-08-13 0:10 ` [U-Boot] [PATCH v6 1/4] " Joe Hershberger
2011-08-14 18:55 ` Mike Frysinger
2011-09-14 1:08 ` Kim Phillips
2011-09-15 9:45 ` Wolfgang Denk
2011-09-15 21:27 ` Albert ARIBAUD
2011-10-12 3:50 ` [U-Boot] [PATCH v7 " Joe Hershberger
2011-10-12 15:55 ` Laurence Withers
2011-11-03 20:53 ` Kim Phillips
2011-11-05 2:24 ` [U-Boot] [PATCH v8 1/4] gpio: Modify common gpio.h to more closely match Linux Joe Hershberger
2011-11-05 17:06 ` Mike Frysinger
2011-11-11 21:55 ` [U-Boot] [PATCH v9 " Joe Hershberger
2011-12-13 0:54 ` Kim Phillips
2011-11-11 21:55 ` [U-Boot] [PATCH v9 2/4] gpio: Replace ARM gpio.h with the common API in include/asm-generic Joe Hershberger
2011-11-11 23:07 ` Kim Phillips
2011-11-17 18:24 ` Joe Hershberger
2011-11-11 21:55 ` [U-Boot] [PATCH v9 3/4] mpc83xx: Add a GPIO driver for the MPC83XX family Joe Hershberger
2011-11-11 21:55 ` [U-Boot] [PATCH v9 4/4] mpc8313erdb: Enable GPIO support on the MPC8313E RDB Joe Hershberger
2011-11-05 2:24 ` [U-Boot] [PATCH v8 2/4] gpio: Replace ARM gpio.h with the common API in include/asm-generic Joe Hershberger
2011-11-07 16:35 ` Stephen Warren
2011-11-07 17:39 ` Mike Frysinger
2011-11-07 17:02 ` Stephen Warren
2011-11-07 17:45 ` Joe Hershberger
2011-11-07 19:02 ` Mike Frysinger
2011-11-05 2:25 ` [U-Boot] [PATCH v8 3/4] mpc83xx: Add a GPIO driver for the MPC83XX family Joe Hershberger
2011-11-05 17:07 ` Mike Frysinger
2011-11-05 2:25 ` [U-Boot] [PATCH v8 4/4] mpc8313erdb: Enable GPIO support on the MPC8313E RDB Joe Hershberger
2011-10-12 3:50 ` [U-Boot] [PATCH v7 2/4] gpio: Modify common gpio.h to more closely match Linux Joe Hershberger
2011-10-12 15:55 ` Laurence Withers
2011-10-12 3:50 ` [U-Boot] [PATCH v7 3/4] mpc83xx: Add a GPIO driver for the MPC83XX family Joe Hershberger
2011-10-12 3:50 ` [U-Boot] [PATCH v7 4/4] mpc8313erdb: Enable GPIO support on the MPC8313E RDB Joe Hershberger
2011-08-13 0:10 ` [U-Boot] [PATCH v6 2/4] gpio: Modify common gpio.h to more closely match Linux Joe Hershberger
2011-08-14 18:55 ` Mike Frysinger
2011-10-06 21:56 ` Wolfgang Denk
2011-08-13 0:10 ` [U-Boot] [PATCH v6 3/4] mpc83xx: Add a GPIO driver for the MPC83XX family Joe Hershberger
2011-10-06 21:55 ` Wolfgang Denk
2011-08-13 0:10 ` [U-Boot] [PATCH v6 4/4] mpc8313erdb: Enable GPIO support on the MPC8313E RDB Joe Hershberger
2011-10-06 21:55 ` Wolfgang Denk
2011-08-12 8:11 ` [U-Boot] [PATCH v5 2/3] mpc83xx: Add a GPIO driver for the MPC83XX family Joe Hershberger
2011-08-12 8:11 ` [U-Boot] [PATCH v5 3/3] mpc8313erdb: Enable GPIO support on the MPC8313E RDB Joe Hershberger
2011-08-10 4:56 ` [U-Boot] [PATCH v4 2/3] mpc83xx: Add a GPIO driver for the MPC83XX family Joe Hershberger
2011-08-10 4:56 ` [U-Boot] [PATCH v4 3/3] mpc8313erdb: Enable GPIO support on the MPC8313E RDB Joe Hershberger
2011-08-09 23:52 ` [U-Boot] [PATCH v2 1/2] mpc83xx: Add a GPIO driver for the MPC83XX family Joe Hershberger
2011-08-09 23:52 ` [U-Boot] [PATCH v2 2/2] mpc8313erdb: Enable GPIO support on the MPC8313E RDB Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E41B175.6080607@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox