[U-Boot] [PATCH 5/9] apf9328: add default board configuration file

Stefano Babic
2011-08-23T09:46:09Z

On 08/15/2011 10:25 PM, Eric Jarrige wrote:
> Hi Stefano,

Hi Eric,

sorry for my late answer. I have missed a point.

>>> +#define CONFIG_EXTRA_ENV_SETTINGS \
>>> + "env_version=" CONFIG_ENV_VERSION "\0" \
>>> + "fileaddr=" MK_STR(CONFIG_SYS_LOAD_ADDR) "\0" \
>>> + "filesize=" MK_STR(CONFIG_SYS_MONITOR_LEN) "\0" \
>>
>> filesize is dynamically computed, you should not add it
>
> We need this variable already initialized at boot time to support the specific imx boot mode from serial port when the user lost the full content of the flash.
> In such case (that is a stressing situation for the user) he can push U-Boot through the serial port and use directly the script "flash_uboot" to recover the original content of the flash. In such a use case this variable is not dynamically computed.

By the way, you reach the same behavior adding a new variable (such as
"monitor_size") with the default value you want and use it in your
scripts. filesize is a special variable in u-boot and it sounds odd to
fix it.

>> Please drop fix ip address. They should not be part of mainline,
>
> Here, I have a problem as our documentation on the wiki armadeus.org is based on this default IP addresses.
> We really need a set of default IP addresses for private network to simplify as much as possible the life of the armadeus project developers.
> I never seen such a restriction in U-Boot doc and moreover there is a set CONFIG_XXIP documented in U-BOOT that confusing me,
> Is there another solution for a complete usable default configuration?

Well, you will find a lot of NAK for patches that set fix IP addresses
in the ML. Even if this default address is described in your
documentation, what happens if two users of yours, as you say they are
newbies, attach their board to the same LAN using the same "default"
address ? Is it not better to explain them they need a *correct* ip
address ?

A default IP address simply does not exist and requires to have a
"default" network (192.168.0.x), with "default" netmask...

If you want to simplify the setup for your users, add dhcp.

> 16MiB is the regular configuration but there are many configurations of boards with different size of memory.
> This set of parameters enables to support every boards at compilation by just changing the value of CONFIG_SYS_SDRAM_MBYTE_SYZE.
> So that the binary generated is fully optimized for each board.

Understood, thanks.

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================