[U-Boot] [PATCH 8/9] DM9000: change some printf to use debug instead

Eric Jarrige
2011-08-11T10:51:47Z

Hi Simon, Hi Detlev,

> Hi Simon,
>
>> Dear Eric Jarrige,
>>
>> On 08/10/2011 10:33 PM, Eric Jarrige wrote:
>>> Signed-off-by: Eric Jarrige<eric.jarrige@armadeus.org>
>>> Cc: Ben Warren<biggerbadderben@gmail.com>
>>> ---
>>> drivers/net/dm9000x.c | 8 ++++----
>>> 1 files changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c
>>> index b5c5573..9cd0195 100644
>>> --- a/drivers/net/dm9000x.c
>>> +++ b/drivers/net/dm9000x.c
>>> @@ -232,7 +232,7 @@ dm9000_probe(void)
>>> id_val |= DM9000_ior(DM9000_PIDL)<< 16;
>>> id_val |= DM9000_ior(DM9000_PIDH)<< 24;
>>> if (id_val == DM9000_ID) {
>>> - printf("dm9000 i/o: 0x%x, id: 0x%x \n", CONFIG_DM9000_BASE,
>>> + DM9000_DBG("dm9000 i/o: 0x%x, id: 0x%x \n", CONFIG_DM9000_BASE,
>>> id_val);
>>> return 0;
>>> } else {
>>> @@ -298,19 +298,19 @@ static int dm9000_init(struct eth_device *dev, bd_t *bd)
>>>
>>> switch (io_mode) {
>>> case 0x0: /* 16-bit mode */
>>> - printf("DM9000: running in 16 bit mode\n");
>>> + DM9000_DBG("DM9000: running in 16 bit mode\n");
>> <snip>
>>
>> I'am just wondering: I see that DM9000_DBG is used all over dm9000 code
>> - do you know the reason why not just use debug()?

dm9000 does not use debug() at all.
That's the reason to fix the printf issues as a first priority by using the DM9000_DBG.

>
> Very likely only historical reasons as the code predates the DEBUG best
> practice. Bow that you've identified it, we should change it ;)
>
Cheers,
Eric