public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tsec: Configure the buffer descriptor bases to always include all of the descriptors
Date: Thu, 11 Aug 2011 16:26:51 +0400	[thread overview]
Message-ID: <4E43CA8B.50900@mvista.com> (raw)
In-Reply-To: <1312960344-1499-1-git-send-email-joe.hershberger@ni.com>

Hello.

On 10-08-2011 11:12, Joe Hershberger wrote:

> Previously only the last N were included based on the current one in use.

> Signed-off-by: Joe Hershberger<joe.hershberger@ni.com>
> Cc: Joe Hershberger<joe.hershberger@gmail.com>
> Cc: Mingkai Hu<Mingkai.hu@freescale.com>
> Cc: Andy Fleming<afleming@freescale.com>
> Cc: Kumar Gala<galak@kernel.crashing.org>
> Cc: Detlev Zundel<dzu@denx.de>
> ---
>   drivers/net/tsec.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)

> diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
> index 78ffc95..1805ca0 100644
> --- a/drivers/net/tsec.c
> +++ b/drivers/net/tsec.c
> @@ -250,8 +250,8 @@ static void startup_tsec(struct eth_device *dev)
>   	txIdx = 0;
>
>   	/* Point to the buffer descriptors */
> -	out_be32(&regs->tbase, (unsigned int)(&rtx.txbd[txIdx]));
> -	out_be32(&regs->rbase, (unsigned int)(&rtx.rxbd[rxIdx]));
> +	out_be32(&regs->tbase, (unsigned int)(&rtx.txbd[0]));
> +	out_be32(&regs->rbase, (unsigned int)(&rtx.rxbd[0]));

    Note that & and [0] are not really needed.

WBR, Sergei

      parent reply	other threads:[~2011-08-11 12:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10  7:12 [U-Boot] [PATCH] tsec: Configure the buffer descriptor bases to always include all of the descriptors Joe Hershberger
2011-08-10 12:29 ` Detlev Zundel
2011-08-10 19:15   ` Joe Hershberger
2011-08-10 19:24     ` Detlev Zundel
2011-08-10 19:49       ` Andy Fleming
2011-08-10 20:59         ` Detlev Zundel
2011-08-10 14:10 ` Andy Fleming
2011-08-10 19:20   ` Joe Hershberger
2011-08-24 22:46     ` Wolfgang Denk
2011-08-24 22:48       ` Joe Hershberger
2011-08-10 21:14 ` Andy Fleming
2011-08-11 12:26 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E43CA8B.50900@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox