From: Tabi Timur-B04825 <B04825@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [u-boot-release] [Patch v3] powerpc/eeprom: cleanup mac command
Date: Thu, 11 Aug 2011 14:55:45 +0000 [thread overview]
Message-ID: <4E43ED71.4020304@freescale.com> (raw)
In-Reply-To: <1313074116-8733-1-git-send-email-yorksun@freescale.com>
York Sun wrote:
> - e.mac_count = simple_strtoul(argv[2], NULL, 16);
> + e.mac_count = simple_strtoul(argv[2], NULL, 10);
You forgot the MAC address index. There's another use of strtoul in the
code that needs to be fixed.
Also, if you use "0" instead of "10", then it should be able to handle
hex as well, just in case someone wants to use it.
next prev parent reply other threads:[~2011-08-11 14:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 14:48 [U-Boot] [Patch v3] powerpc/eeprom: cleanup mac command York Sun
2011-08-11 14:55 ` Tabi Timur-B04825 [this message]
2011-08-11 15:03 ` [U-Boot] [u-boot-release] " York Sun
2011-08-11 18:40 ` Tabi Timur-B04825
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E43ED71.4020304@freescale.com \
--to=b04825@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox