[U-Boot] [PATCH v 1/3] arm: do not force d-cache enable on all boards

Albert ARIBAUD
2011-08-02T15:58:04Z

Le 02/08/2011 16:35, Jason Liu a ?crit :
> Hi, Albert,
>
> 2011/8/2 Albert ARIBAUD<albert.u.boot@aribaud.net>:
>> Hi Jason,
>>
>> Le 01/08/2011 18:33, Jason Liu a ?crit :
>>
>>> Maybe there will be many many duplicated code like this, do you wish that?
>>
>> I don't think this will or should be duplicated for each ARM board; more
>> like suplicated by SoC, or more precisely, by ARM implementation (i.e., one
>> cache handling for each of arch/arm/<architecture>/<implementation>) -- more
>> or less.
>
> Yes, not each ARM board, but should be a lot as the followings,
>
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 mx31
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 mx35
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 omap24xx
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 s3c64xx
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 tnetv107x
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-29 15:21 lpc2292
> drwxr-xr-x 2 r64343 r64343 4096 2011-04-13 13:00 s3c4510b
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 a320
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 at91rm9200
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 ep93xx
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 ks8695
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 s3c24x0
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 armada100
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 davinci
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 kirkwood
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 mb86r0x
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 mx25
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 mx27
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 nomadik
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 omap
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 orion5x
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 pantheon
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 spear
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 versatile
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-29 19:12 mx5
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-29 10:20 omap3
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-28 17:23 omap4
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 omap-common
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 10:46 s5pc1xx
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-26 17:37 s5pc2xx
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 s5p-common
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 tegra2
> drwxr-xr-x 2 r64343 r64343 4096 2011-07-27 11:04 u8500
> drwxr-xr-x 3 r64343 r64343 4096 2011-07-29 15:21 npe
>
> All these arm/<architecture>/<implementation>s will have the duplicated code.
> can we consolidate it?

It might be (partially) possible to factorize some of the code from
implementations of the same <architecture> level (e.g., arm926ejs
architecture for orion5x, kirkwood, etc).

This will be something that developers (and reviewers) will need to keep
in mind when submitting patches that enable caches on ARM boards: such
code should be split across ARM architecture and implementation, so that
other implementations of the same arch will benefit from the common
architecture part.

> Jason

Amicalement,
--
Albert.