[U-Boot] [PATCH 2/2] beagleboard: enable HUB power on XM boards

[U-Boot] [PATCH 2/2] beagleboard: enable HUB power on XM boards

[Eric Bénard]

LEDA needs to be at level 0 to enable HUB_3V3

Signed-off-by: Eric B?nard <eric@eukrea.com>
---
 board/ti/beagle/beagle.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/board/ti/beagle/beagle.c b/board/ti/beagle/beagle.c
index ab50514..7509916 100644
--- a/board/ti/beagle/beagle.c
+++ b/board/ti/beagle/beagle.c
@@ -299,7 +299,10 @@ int misc_init_r(void)
 		setenv(expansion_config.env_var, expansion_config.env_setting);
 
 	twl4030_power_init();
-	twl4030_led_init(TWL4030_LED_LEDEN_LEDAON | TWL4030_LED_LEDEN_LEDBON);
+	if (get_board_revision() < REVISION_C4)
+		twl4030_led_init(TWL4030_LED_LEDEN_LEDBON); /* Enable HUB PWR */
+	else
+		twl4030_led_init(TWL4030_LED_LEDEN_LEDAON | TWL4030_LED_LEDEN_LEDBON);
 
 	/* Configure GPIOs to output */
 	writel(~(GPIO23 | GPIO10 | GPIO8 | GPIO2 | GPIO1), &gpio6_base->oe);
-- 
1.7.0.4

[U-Boot] [PATCH 2/2] beagleboard: enable HUB power on XM boards

[Christian Spielberger]

Hello Eric,

we have both, a beagle xM-B and a beagle xM-C. The following works on 
both boards and is different from your patch. It is not possible to 
differentiate between Rev xM-A and xM-B. Anyway, the only difference is 
in the processors silicon revision (ES 1.0 to ES 1.1).

regards,
chris.

---
@@ -299,7 +309,15 @@ int misc_init_r(void)
                 setenv(expansion_config.env_var, 
expansion_config.env_setting);

         twl4030_power_init();
-       twl4030_led_init(TWL4030_LED_LEDEN_LEDAON | 
TWL4030_LED_LEDEN_LEDBON);
+       switch (get_board_revision()) {
+               case REVISION_XM_C:
+               case REVISION_C4:
+                       twl4030_led_init( TWL4030_LED_LEDEN_LEDAON | 
TWL4030_LED_LEDEN_LEDBON );
+                       break;
+               default:
+                       twl4030_led_init( TWL4030_LED_LEDEN_LEDBON );
+                       break;
+       }

         /* Configure GPIOs to output */
         writel(~(GPIO23 | GPIO10 | GPIO8 | GPIO2 | GPIO1), 
&gpio6_base->oe);

[U-Boot] [PATCH 2/2] beagleboard: enable HUB power on XM boards

[Eric Bénard]

Hi Christian,

On 14/06/2011 16:27, Christian Spielberger wrote:
> we have both, a beagle xM-B and a beagle xM-C. The following works on
> both boards and is different from your patch. It is not possible to
> differentiate between Rev xM-A and xM-B. Anyway, the only difference is
> in the processors silicon revision (ES 1.0 to ES 1.1).
>
> regards,
> chris.
>
> ---
> @@ -299,7 +309,15 @@ int misc_init_r(void)
>                   setenv(expansion_config.env_var,
> expansion_config.env_setting);
>
>           twl4030_power_init();
> -       twl4030_led_init(TWL4030_LED_LEDEN_LEDAON |
> TWL4030_LED_LEDEN_LEDBON);
> +       switch (get_board_revision()) {
> +               case REVISION_XM_C:
> +               case REVISION_C4:
> +                       twl4030_led_init( TWL4030_LED_LEDEN_LEDAON |
> TWL4030_LED_LEDEN_LEDBON );
> +                       break;
> +               default:
> +                       twl4030_led_init( TWL4030_LED_LEDEN_LEDBON );
> +                       break;
> +       }
>
>           /* Configure GPIOs to output */
>           writel(~(GPIO23 | GPIO10 | GPIO8 | GPIO2 | GPIO1),
> &gpio6_base->oe);

ok thanks, I'll include it with an update to the previous patch that fix a 
problem when loading the kernel with USB clocks enabled.

Eric

[U-Boot] [PATCH 2/2] beagleboard: enable HUB power on XM boards

[Jason Kridner]

On Tue, Jun 14, 2011 at 10:33 AM, Eric B?nard <eric@eukrea.com> wrote:
> Hi Christian,
>
> On 14/06/2011 16:27, Christian Spielberger wrote:
>> we have both, a beagle xM-B and a beagle xM-C. The following works on
>> both boards and is different from your patch. It is not possible to
>> differentiate between Rev xM-A and xM-B. Anyway, the only difference is
>> in the processors silicon revision (ES 1.0 to ES 1.1).
>>
...
>
> ok thanks, I'll include it with an update to the previous patch that fix a
> problem when loading the kernel with USB clocks enabled.

Eric, Christian,

Are either of you still planning to send an updated patch to get USB
working on BB-xM-A/B (and not break it for <=BB-C5 and >=BB-xM-C)?

Regards,
Jason

[U-Boot] [PATCH 2/2] beagleboard: enable HUB power on XM boards

[Eric Bénard]

Hi Jason,

On 12/08/2011 23:09, Jason Kridner wrote:
> On Tue, Jun 14, 2011 at 10:33 AM, Eric B?nard<eric@eukrea.com>  wrote:
>> Hi Christian,
>>
>> On 14/06/2011 16:27, Christian Spielberger wrote:
>>> we have both, a beagle xM-B and a beagle xM-C. The following works on
>>> both boards and is different from your patch. It is not possible to
>>> differentiate between Rev xM-A and xM-B. Anyway, the only difference is
>>> in the processors silicon revision (ES 1.0 to ES 1.1).
>>>
> ...
>>
>> ok thanks, I'll include it with an update to the previous patch that fix a
>> problem when loading the kernel with USB clocks enabled.
>
> Eric, Christian,
>
> Are either of you still planning to send an updated patch to get USB
> working on BB-xM-A/B (and not break it for<=BB-C5 and>=BB-xM-C)?
>
I do have this updated patch ready on a PC at work so I should be able to send 
it next week
Eric