From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hong Xu Date: Mon, 15 Aug 2011 15:00:59 +0800 Subject: [U-Boot] [PATCH 1/3] ARM: Clean arch/arm/lib/cache.c In-Reply-To: <201108110638.50692.marek.vasut@gmail.com> References: <1313029189-18536-1-git-send-email-hong.xu@atmel.com> <1313029189-18536-3-git-send-email-hong.xu@atmel.com> <201108110638.50692.marek.vasut@gmail.com> Message-ID: <4E48C42B.5050906@atmel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, On 08/11/2011 12:38 PM, Marek Vasut wrote: > On Thursday, August 11, 2011 04:19:45 AM Hong Xu wrote: >> The default cache operations defined in arch/arm/lib/cache.c >> do not perform any real cache operation, and instead a WARNING >> will be emitted. >> >> Signed-off-by: Hong Xu >> Tested-by: Elen Song >> CC: Albert Aribaud >> CC: Aneesh V >> CC: Marek Vasut >> CC: Reinhard Meyer >> CC: Heiko Schocher >> --- >> arch/arm/lib/cache.c | 55 >> ++++++++++++++++++++++++++++--------------------- 1 files changed, 31 >> insertions(+), 24 deletions(-) >> >> diff --git a/arch/arm/lib/cache.c b/arch/arm/lib/cache.c >> index 92b61a2..6af05ec 100644 >> --- a/arch/arm/lib/cache.c >> +++ b/arch/arm/lib/cache.c >> @@ -20,36 +20,43 @@ >> * Foundation, Inc., 59 Temple Place, Suite 330, Boston, >> * MA 02111-1307 USA >> */ >> +#include >> +#include >> >> -/* for now: just dummy functions to satisfy the linker */ >> +#define EMIT_WARNING printf("WARNING: %s - CPU cache operation is not " \ >> +"implemented!\n", __func__) > > Maybe use debug() ? Or make the emission of warning conditional, somehow I have > the feeling this will make some people unhappy. Just my feelings: It's noisy but it'll give strong message to the user even if the DEBUG is not opened :-) BR, Eric > Otherwise looks nice and clean. >> >> -#include >> +/* [...]