From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] fdt: Add a fdt_set_node_status function
Date: Mon, 15 Aug 2011 13:12:17 -0500 [thread overview]
Message-ID: <4E496181.7020104@freescale.com> (raw)
In-Reply-To: <op.vz8khtvaz91x4h@localhost.localdomain>
On 08/14/2011 10:40 PM, Lan Chunhe wrote:
> On Sat, 13 Aug 2011 00:24:33 +0800, Scott Wood <scottwood@freescale.com>
> wrote:
>
>> fdt_get_alias() is not needed -- do_fixup_by_path() calls
>> fdt_path_offset() which handles aliases.
>>
>> Instead of something specific to status, how about adding
>> do_fixup_by_path_string()?
>
> I think that function of do_fixup_by_path should have
> completed that function.
do_fixup_by_path_string() would just be an inline wrapper for
do_fixup_by_path() that calls strlen on the argument.
And then you could just do:
do_fixup_by_path_string(fdt, "nand_flash", "status", "okay");
I don't see a need for a function dedicated to the status property.
-Scott
next prev parent reply other threads:[~2011-08-15 18:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 3:18 [U-Boot] [PATCH 1/2] fdt: Add a fdt_set_node_status function Chunhe Lan
2011-08-12 16:24 ` Scott Wood
2011-08-15 3:40 ` Lan Chunhe
2011-08-15 18:12 ` Scott Wood [this message]
2011-08-16 7:24 ` Lan Chunhe
2011-08-15 0:08 ` Tabi Timur-B04825
2011-08-15 3:03 ` Lan Chunhe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E496181.7020104@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox