From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 15 Aug 2011 13:12:17 -0500 Subject: [U-Boot] [PATCH 1/2] fdt: Add a fdt_set_node_status function In-Reply-To: References: <1313119113-26302-1-git-send-email-Chunhe.Lan@freescale.com> <4E4553C1.4020600@freescale.com> Message-ID: <4E496181.7020104@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/14/2011 10:40 PM, Lan Chunhe wrote: > On Sat, 13 Aug 2011 00:24:33 +0800, Scott Wood > wrote: > >> fdt_get_alias() is not needed -- do_fixup_by_path() calls >> fdt_path_offset() which handles aliases. >> >> Instead of something specific to status, how about adding >> do_fixup_by_path_string()? > > I think that function of do_fixup_by_path should have > completed that function. do_fixup_by_path_string() would just be an inline wrapper for do_fixup_by_path() that calls strlen on the argument. And then you could just do: do_fixup_by_path_string(fdt, "nand_flash", "status", "okay"); I don't see a need for a function dedicated to the status property. -Scott