From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Tue, 16 Aug 2011 15:14:50 +0400 Subject: [U-Boot] [PATCH 5/7] led: Fixed setting of STATUS_LED_BIT1 when led_name is 'all' In-Reply-To: <1313462527-3876-5-git-send-email-agnel.joel@gmail.com> References: <1313462527-3876-1-git-send-email-agnel.joel@gmail.com> <1313462527-3876-5-git-send-email-agnel.joel@gmail.com> Message-ID: <4E4A512A.7030304@mvista.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello. On 16-08-2011 6:42, Joel A Fernandes wrote: > Fix for only one led getting set or reset when the led_name is 'all' > Previous discussion: > http://lists.denx.de/pipermail/u-boot/2011-May/093068.html > Signed-off-by: Joel A Fernandes > Signed-off-by: Jason Kridner > --- > common/cmd_led.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > diff --git a/common/cmd_led.c b/common/cmd_led.c > index d14dd5a..d3a8450 100644 > --- a/common/cmd_led.c > +++ b/common/cmd_led.c > @@ -108,7 +108,9 @@ int do_led (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > } else { > __led_set(led_commands[i].mask, state); > } > - break; > + /* Need to set only 1 led if led_name wasn't 'all' */ > + if(strcmp("all", argv[1]) != 0) There should be space after *if* -- run patches thry checkpatch.pl. WBR, Sergei