From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Wed, 17 Aug 2011 15:15:09 +0200 Subject: [U-Boot] [PATCH] Makefile : fix generation of cpu related asm-offsets.h In-Reply-To: <4E4BBC01.4030102@arcor.de> References: <1313575934-15552-1-git-send-email-sbabic@denx.de> <4E4BBC01.4030102@arcor.de> Message-ID: <4E4BBEDD.8050604@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/17/2011 03:02 PM, Matthias Wei?er wrote: > Dear Stefano > > Am 17.08.2011 12:12, schrieb Stefano Babic: >> commit 0edf8b5b2fa0d210ebc4d6da0fd1aceeb7e44e47 breaks >> building on a different directory with the O= parameter. >> The patch wil fix this issue, generating always asm-offsets.h before >> the other targets. >> >> Signed-off-by: Stefano Babic >> --- >> >> Note: the patch fixes the issue, however I generate an empty >> asm-offsets.c >> for boards that do not have one. Is there a better way to reach the >> goal ? > > Wouldn't it be possible to just create an empty asm-offsets.h if there > is no asm-offsets.c? Yes, this is surely possible - but I do not know another clean way to do this as adding an if..then..fi script inside the rule, as I did now creating an empty asm-offsets.c. Really I wanted to fix this issue changing the dependencies, but I have not found a solution. Now it works (as for generic-asm-offsets.h) because asm-offsets.h is always generated as first target. > And maybe it is handy to add the auto-generated files (asm-offsets.s/h) > to the list of removed files of the clean or distclean target. Agree, they must be added as well. Regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================