From: Valentin Longchamp <valentin.longchamp@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/8] POST: add post_log_res field for post results in global data
Date: Thu, 18 Aug 2011 13:00:21 +0200 [thread overview]
Message-ID: <4E4CF0C5.2060607@keymile.com> (raw)
In-Reply-To: <201108181239.21410.marek.vasut@gmail.com>
On 08/18/2011 12:39 PM, Marek Vasut wrote:
> On Wednesday, August 03, 2011 02:37:01 PM Valentin Longchamp wrote:
>> The current post_log_word in global data is currently split into 2x
>> 16 bits: half for the test start, half for the test success.
>> Since we alredy have more than 16 POST tests defined and more could
>> be defined, this may result in an overflow and the post_output_backlog
>> would not work for the tests defined further of these 16 positions.
>>
>> An additional field is added to global data so that we can now support up
>> to 32 (depending of architecture) tests. The post_log_word is only used
>> to record the start of the test and the new field post_log_res for the
>> test success (or failure). The post_output_backlog is for this change
>> also adapted.
>>
>> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
>
> [...]
>
>> @@ -144,12 +145,12 @@ int post_bootmode_get (unsigned int *last_test)
>> /* POST tests run before relocation only mark status bits .... */
>> static void post_log_mark_start ( unsigned long testid )
>> {
>> - gd->post_log_word |= (testid)<<16;
>> + gd->post_log_word |= testid;
>
> I think you can just assign it if you changed the meaning. Still, what if we
> will have more than 32 tests?
>
Yes, this will not work anymore when we have more than 32 tests. But we already
have more than 16 tests so there was already a flaw. This at least corrects this
flaw.
The problem is that this has to stay in the global_data that has to remain
small, so a u32 for bit setting has the great advantage of being small.
--
Valentin Longchamp
Embedded Software Engineer
Hardware and Chip Integration
______________________________________
KEYMILE AG
Schwarzenburgstr. 73
CH-3097 Liebefeld
Phone +41 31 377 1318
Fax +41 31 377 1212
valentin.longchamp at keymile.com
www.keymile.com
______________________________________
KEYMILE: A Specialist as a Partner
next prev parent reply other threads:[~2011-08-18 11:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 12:36 [U-Boot] [PATCH 0/8 RFC] POST: support for km_arm and mem_regions test definition Valentin Longchamp
2011-08-03 12:37 ` [U-Boot] [PATCH 1/8] POST/arm: adaptations needed for POST on ARM to work Valentin Longchamp
2011-08-14 19:07 ` Mike Frysinger
2011-08-15 9:09 ` Valentin Longchamp
2011-08-16 18:03 ` Mike Frysinger
2011-08-18 10:07 ` Marek Vasut
2011-08-18 14:31 ` Mike Frysinger
2011-08-18 17:01 ` Marek Vasut
2011-08-18 17:42 ` Mike Frysinger
2011-08-03 12:37 ` [U-Boot] [PATCH 2/8] POST: add post_log_res field for post results in global data Valentin Longchamp
2011-08-18 10:39 ` Marek Vasut
2011-08-18 11:00 ` Valentin Longchamp [this message]
2011-08-18 12:56 ` Marek Vasut
2011-08-03 12:37 ` [U-Boot] [PATCH 3/8] POST: make env test flags fetching optional Valentin Longchamp
2011-08-03 12:37 ` [U-Boot] [PATCH 4/8] POST: drivers/memory.c coding style cleanup Valentin Longchamp
2011-08-14 19:14 ` Mike Frysinger
2011-08-03 12:37 ` [U-Boot] [PATCH 5/8] POST: add new memory regions test Valentin Longchamp
2011-08-03 12:37 ` [U-Boot] [PATCH 6/8] POST/km_arm: add POST memory tests infrastructure Valentin Longchamp
2011-08-14 19:49 ` Mike Frysinger
2011-08-15 9:10 ` Valentin Longchamp
2011-08-18 10:44 ` Marek Vasut
2011-09-02 15:25 ` Mike Frysinger
2011-08-03 12:37 ` [U-Boot] [PATCH 7/8] km_arm: change CONFIG_SYS_TEXT_BASE to end of RAM Valentin Longchamp
2011-08-03 12:37 ` [U-Boot] [PATCH 8/8] km_arm: enable POST for these boards Valentin Longchamp
2011-08-04 10:36 ` Sergei Shtylyov
2011-08-15 9:11 ` Valentin Longchamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4CF0C5.2060607@keymile.com \
--to=valentin.longchamp@keymile.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox